Re: [PATCH] Fix "Binary trash when launching ppp"

It looks to me like the declaration of that array is being done earlier 
to make it persistent for something later.

the removal of it in some nested structure could indicate that some 
other part of the code tries to read it in some cases, and because its 
inside a nested loop, the array is emptied after falling out of the 
loop.  Just a guess without looking at the whole file.

~Phil

On 2/6/2013 8:30 PM, Brady, Charlie wrote:
> On Wed, Feb 6, 2013 at 6:42 PM, Christoph Biedl
> <[email protected]> wrote:
>> Description: Fix "Binary trash when launching ppp"
> What does  "Binary trash when launching ppp" mean, and how does this fix it?
>
>> Author: "[email protected]" <[email protected]>
>> Bug-Debian: http://bugs.debian.org/693196
>>
>> --- a/pptpctrl.c
>> +++ b/pptpctrl.c
>> @@ -660,6 +660,7 @@
>>          char *pppd_argv[16];
>>          int an = 0;
>>          sigset_t sigs;
>> +       char pppInterfaceIPs[33];
>>
>>          pppd_argv[an++] = ppp_binary;
>>
>> @@ -760,7 +761,6 @@
>>          }
>>
>>          if (*pppaddrs[0] || *pppaddrs[1]) {
>> -               char pppInterfaceIPs[33];
>>                  sprintf(pppInterfaceIPs, "%s:%s", pppaddrs[0], pppaddrs[1]);
>>                  pppd_argv[an++] = pppInterfaceIPs;
>>          }
>>
>>
>> ------------------------------------------------------------------------------
>> Free Next-Gen Firewall Hardware Offer
>> Buy your Sophos next-gen firewall before the end March 2013
>> and get the hardware for free! Learn more.
>> http://p.sf.net/sfu/sophos-d2d-feb
>> _______________________________________________
>> Poptop-server mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/poptop-server


------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb