Re: [PATCH] Fix "Binary trash when launching ppp"
James Cameron <[email protected]> Thu, 7 Feb 2013 14:56:47 +1100
| Newsgroups | gmane.network.poptop |
|---|---|
| Organization | Netrek Vanilla Server Dictator |
| Message-ID | <[email protected]> |
The buffer was auto allocated in the code block of the if statement, and the pointer was saved in pppd_argv, but once the code block exits the pointer is invalid and will be reused by later code blocks. The patch moves the buffer into function scope instead. -- James Cameron http://quozl.linux.org.au/ ------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb