Re: [PATCH] Code cleanup (warning fixes)
John Lauro <[email protected]> Fri, 18 Oct 2013 06:55:03 -0400 (EDT)
| Newsgroups | gmane.network.poptop |
|---|---|
| Message-ID | <[email protected]> |
Looks good. Figured out the proper git repo after I submitted the patches. Sorry about that... Any future patches I'll include a git link to pull from in addition to the diff, and plan to create at least one more group in the next week or two to clean up some more minor issues. The repo has more recent commits, but the download file links at https://sourceforge.net/projects/poptop/files/ and http://poptop.sourceforge.net/dox/ is 6 years old (1.3.4 dated Apr 15 2007). Many people probably do not check the repository, assuming the home page is latest stable (by many, that would be hundreds of downloads per week according to sourceforge's stats). ----- Original Message ----- > From: "James Cameron" <[email protected]> > To: "John Lauro" <[email protected]> > Cc: [email protected] > Sent: Friday, October 18, 2013 4:14:10 AM > Subject: Re: [Poptop-server] [PATCH] Code cleanup (warning fixes) > > Thanks, reviewed and merged. > > Your patches failed to apply initally, so they were manually split, > reviewed, and committed, please check for differences against your > copy. Many of your whitespace changes were undone as well. > > git://git.code.sf.net/p/poptop/git is the current repository, and has > changes more recent than six years ago, please check again? > > (this repository was converted from CVS on 19th Feb 2013) > > -- > James Cameron > http://quozl.linux.org.au/ > ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk