Re: [PATCH]

I don't know much about rpmbuild, so there is probably a better fix.  However, make builds and installs it either way (which seems off, note the patch to bcrelay.c), and rpmbuild on my system gives an error if the file is conditiona when it is still built.  So, with it conditional rpmbuild fails.

----- Original Message -----
> From: "Charlie Brady" <[email protected]>
> To: "John Lauro" <[email protected]>
> Cc: "James Cameron" <[email protected]>, "poptop-server" <[email protected]>
> Sent: Wednesday, October 23, 2013 11:30:33 AM
> Subject: Re: [Poptop-server] [PATCH]
> 
> On Wed, Oct 23, 2013 at 11:23 AM, John Lauro
> <[email protected]> wrote:
> 
> > -%{!?_without_bcrelay:%{_sbindir}/bcrelay}
> > +%{_sbindir}/bcrelay
> 
> Shouldn't that still be conditional?
> 
> --
> This e-mail (including any attachments) is for the sole use of the
> intended
> recipient(s) and may contain information that is confidential and/or
> protected by legal privilege. Any unauthorized review, use, copy,
> disclosure or distribution of this e-mail is strictly prohibited. If
> you
> are not the intended recipient, please notify Mitel immediately and
> destroy
> all copies of this e-mail.  Mitel does not accept any liability for
> breach
> of security, error or virus that may result from the transmission of
> this
> message.
> 

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk