[PATCH 1/1] Do you think it's reasonable to show the port number on title?

Aaron Lewis <[email protected]> Tue, 8 Jan 2013 14:14:27 +0800
Newsgroups gmane.network.rdesktop.devel
Message-ID <CAJZVxR=Z4QnmGucPwkO+MQJPgUfbrcx-bxcGLrsQOObyVvqM6Q@mail.gmail.com>
Hi,

I run rdesktop with virtualbox's internal rdp server, so all
connection are for localhost
(I know I can use -T option, but .. )

But I still think showing the port number on title bar is reasonable...

--- rdesktop-1.7.1/rdesktop.c	2013-01-07 17:43:13.710045134 +0800
+++ rdesktop-1.7.1.my/rdesktop.c	2013-01-07 17:43:26.996711845 +0800
@@ -967,8 +967,7 @@

 	if (g_title[0] == 0)
 	{
-		strcpy(g_title, "rdesktop - ");
-		strncat(g_title, server, sizeof(g_title) - sizeof("rdesktop - "));
+        snprintf(g_title, sizeof(g_title), "rdesktop - %s:%d",
server, g_tcp_port_rdp);
 	}

 #ifdef RDP2VNC

What do you think?

-- 
Best Regards,
Aaron Lewis - PGP: 0xDFE6C29E ( http://keyserver.veridis.com )
Finger Print: 9482 448F C7C3 896C 1DFE 7DD3 2492 A7D0 DFE6 C29E

------------------------------------------------------------------------------
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills now (including 2012) with LearnDevNow -
200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only - learn more at:
http://p.sf.net/sfu/learnmore_122512