Re: [PATCH 1/1] Do you think it's reasonable to show the port number on title?

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--789238529-642278800-1357630253=:18254
Content-Type: TEXT/PLAIN; CHARSET=UTF-8; FORMAT=flowed
Content-ID: <[email protected]>
Content-Transfer-Encoding: quoted-printable


I think most "normal" users will think it's ugly to see :3389 all the=20
time... Perhaps only show the port if not 3389?

Rgds,
Peter

On Tue, 8 Jan 2013, Aaron Lewis wrote:

> Hi,
>
> I run rdesktop with virtualbox's internal rdp server, so all
> connection are for localhost
> (I know I can use -T option, but .. )
>
> But I still think showing the port number on title bar is reasonable...
>
> --- rdesktop-1.7.1/rdesktop.c	2013-01-07 17:43:13.710045134 +0800
> +++ rdesktop-1.7.1.my/rdesktop.c	2013-01-07 17:43:26.996711845 +0800
> @@ -967,8 +967,7 @@
>
> 	if (g_title[0] =3D=3D 0)
> 	{
> -		strcpy(g_title, "rdesktop - ");
> -		strncat(g_title, server, sizeof(g_title) - sizeof("rdesktop - "));
> +        snprintf(g_title, sizeof(g_title), "rdesktop - %s:%d",
> server, g_tcp_port_rdp);
> 	}
>
> #ifdef RDP2VNC
>
> What do you think?
>
> --=20
> Best Regards,
> Aaron Lewis - PGP: 0xDFE6C29E ( http://keyserver.veridis.com )
> Finger Print: 9482 448F C7C3 896C 1DFE 7DD3 2492 A7D0 DFE6 C29E
>
> -----------------------------------------------------------------------=
-------
> Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
> and more. Get SQL Server skills now (including 2012) with LearnDevNow -
> 200+ hours of step-by-step video tutorials by Microsoft MVPs and expert=
s.
> SALE $99.99 this month only - learn more at:
> http://p.sf.net/sfu/learnmore_122512
> _______________________________________________
> rdesktop-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/rdesktop-devel
>


---
Peter =C3=85strand		ThinLinc Chief Developer
Cendio AB		http://cendio.com
Teknikringen 8		http://twitter.com/ThinLinc
583 30 Link=C3=B6ping	http://facebook.com/ThinLinc
Phone: +46-13-214600	http://plus.google.com/112509906846170010689
--789238529-642278800-1357630253=:18254
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
and more. Get SQL Server skills now (including 2012) with LearnDevNow -
200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only - learn more at:
http://p.sf.net/sfu/learnmore_122512
--789238529-642278800-1357630253=:18254
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
rdesktop-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rdesktop-devel

--789238529-642278800-1357630253=:18254--