Re: Problem with key '2' (kp_downarrow) on numpad

Peter Åstrand <[email protected]>
Newsgroups gmane.network.rdesktop.user
Message-ID <[email protected]>
On Thu, 15 Mar 2007, Jay Sorg wrote:

> > Thanks Jay! That solved the problem.

> I think this may be something that we should fix in rdesktop. The 
> default behavior for rdesktop is to always leave the Num Lock off and 
> only toggle it when needed.  I think this is for some flexibility with 
> other keymaps.

It's also necessary when rdesktop is used from VNC and similiar systems, 
since VNC currently lacks numlock sync. 


> The problem is rdesktop sends for example if I press '2' on the keypad
> Num lock on
> 2 key down
> Num lock off
> 2 key up.
> As you can see, at the point of the '2 key up' its really an 'arrow
> down key up' at that point cause the num lock is off.  It should send
> Num lock on
> 2 key down
> 2 key up.
> Num lock off
> I've been meaning to ask Peter about this.  I just tested, it seems to
> do this with the latest cvs version and I think its done this for a
> very long time.
> Peter, what do you think?
> 
> This little patch seems to fix it for me.

Thanks. This looks good. I've tested all testcases listed in 
keymapping.txt and I cannot find any regression. 

I've committed this fix now. 

Regards, 
---
Peter Åstrand		ThinLinc Chief Developer
Cendio AB		http://www.cendio.se
Teknikringen 3
583 30 Linköping	Phone: +46-13-21 46 00

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
rdesktop-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rdesktop-users
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.