Re: Windows makefile is obsolete

[*Marcin Wiśniewski*, ([email protected])]
[when: 12 września 2006, now: 25 stycznia 2007]

> Hello slrn-user,

>   Both version, .w32 and g32.

So, i looked in some places, replaced all chmap with charset, added
few random spaces, changed some code and slrn compiled.
But:
It is awfully unstable, crashes when i try to load more than ~50
headers.
Non-Ascii letters are unreadable.

So, it means that i made errors somewhere and i would love if someone
point them to me.

Makefile is attached, on end of post are compile warnings. I can
upload compiled binary if it is necessary.
Slang 2.0.7, slrn downloaded today from cvs.
D:\sbin\MinGW\bin>gcc -v
Reading specs from ../lib/gcc-lib/mingw32/3.2.3/specs
Configured    with:    ../gcc/configure    --with-gcc    --with-gnu-ld
--with-gnu-as    --host=mingw32    --target=mingw32    --prefix=/mingw
--enable-threads     --disable-nls     --enable-languages=c++,f77,objc
--disable-win32-registry --disable-shared --enable-sjlj-exceptions
Thread model: win32
gcc version 3.2.3 (mingw special 20030504-1)

I had to make 2 changes in post.c:
post.c: In function `cc_article':
post.c:541: `buf' undeclared (first use in this function)
post.c:541: (Each undeclared identifier is reported only once
post.c:541: for each function it appears in.)
I added "char buf [256];"

post.c: In function `slrn_trim_references_header':
post.c:381: invalid operands to binary *
I changed  "6*p = ' ';" to "p = ' ';"



Compiler warnings:

art.c: In function `insert_followup_format':
art.c:2677: warning: comparison between signed and unsigned
art.c: In function `save_article_as_unix_mail':
art.c:4246: warning: unused variable `undo_mime'
art.c: In function `slrn_pipe_article_to_cmd':
art.c:4624: warning: `lines' might be used uninitialized in this function
art.c: In function `cancel_article':
art.c:6884: warning: unused variable `can_key'
d:/sbin/mingw/include/winnt.h: At top level:
art.c:2438: warning: `art_undo_modifications' defined but not used
charset.c: In function `slrn_convert_substring':
charset.c:170: warning: unused parameter `str'
charset.c:170: warning: unused parameter `offset'
charset.c:170: warning: unused parameter `len'
charset.c:170: warning: unused parameter `to_charset'
charset.c:170: warning: unused parameter `from_charset'
charset.c:170: warning: unused parameter `test'
charset.c:185: warning: control reaches end of non-void function
charset.c: In function `slrn_convert_article':
charset.c:243: warning: unused parameter `a'
charset.c:243: warning: unused parameter `to_charset'
charset.c:243: warning: unused parameter `from_charset'
charset.c:274: warning: control reaches end of non-void function
charset.c: In function `slrn_test_convert_article':
charset.c:277: warning: unused parameter `a'
charset.c:277: warning: unused parameter `to_charset'
charset.c:277: warning: unused parameter `from_charset'
charset.c:381: warning: control reaches end of non-void function
help.c:601: warning: `TermcapNames' defined but not used
mime.c: In function `decode_quoted_printable':
mime.c:251: warning: unused parameter `strip_8bit'
mime.c: In function `slrn_mime_process_article':
mime.c:766: warning: `return' with no value, in function returning non-void
mime.c:804: warning: `return' with no value, in function returning non-void
mime.c:823: warning: this function may return with or without a value
mime.c: In function `fold_line':
mime.c:1024: warning: unused variable `linelen'
mime.c: In function `encode_string':
mime.c:1108: warning: unused variable `total'
mime.c: In function `min_encode':
mime.c:1225: warning: comparison between signed and unsigned
mime.c: In function `encode_localpart':
mime.c:1413: warning: unused parameter `from_charset'
mime.c: In function `encode_domain':
mime.c:1474: warning: unused parameter `from_charset'
mime.c: In function `encode_domainlit':
mime.c:1526: warning: unused parameter `from_charset'
mime.c: In function `from_encode':
mime.c:1570: warning: comparison between signed and unsigned
mime.c:1564: warning: unused variable `i'
In file included from misc.c:70:
d:/sbin/mingw/include/windows.h:90:2: warning: #warning "The  Win32_Winsock macro name is deprecated.    Please use __USE_W32_SOCKETS instead"
misc.c: In function `top_status_line_cb':
misc.c:242: warning: `%x' yields only last 2 digits of year in some locales
misc.c: In function `slrn_write_nchars':
misc.c:468: warning: comparison between signed and unsigned
misc.c:484: warning: comparison between signed and unsigned
misc.c:488: warning: comparison between signed and unsigned
misc.c:498: warning: comparison between signed and unsigned
misc.c:507: warning: comparison between signed and unsigned
misc.c:533: warning: comparison between signed and unsigned
misc.c:459: warning: `prev' might be used uninitialized in this function
misc.c:465: warning: `prevlen' might be used uninitialized in this function
misc.c: In function `slrn_custom_printf':
misc.c:713: warning: unused variable `i'
misc.c: In function `slrn_mail_file':
misc.c:1167: warning: unused parameter `subject'
misc.c: In function `make_quoted_string':
misc.c:3065: warning: suggest parentheses around assignment used as truth value
post.c: In function `slrn_trim_references_header':
post.c:381: warning: assignment makes pointer from integer without a cast
post.c: In function `prepare_body':
post.c:819: warning: unused variable `tmp'
post.c:815: warning: unused parameter `mail'
post.c: In function `slrn_prepare_file_for_posting':
post.c:895: warning: `iret' might be used uninitialized in this function
post.c: In function `slrn_post':
post.c:1712: warning: unused variable `tmp'
post.c:1715: warning: unused variable `convert'
In file included from sltcp.c:61,
                 from server.c:58:
d:/sbin/mingw/include/windows.h:90:2: warning: #warning "The  Win32_Winsock macro name is deprecated.    Please use __USE_W32_SOCKETS instead"
startup.c: In function `set_charset_fun':
startup.c:525: warning: control reaches end of non-void function
startup.c: In function `slrn_set_object_color':
startup.c:1115: warning: unused parameter `attr'
In file included from sltcp.c:61,
                 from slrnpull.c:75:
d:/sbin/mingw/include/windows.h:90:2: warning: #warning "The  Win32_Winsock macro name is deprecated.    Please use __USE_W32_SOCKETS instead"
In file included from slrnpull.c:88:
mime.c: In function `decode_quoted_printable':
mime.c:251: warning: unused parameter `strip_8bit'
gw32objs/slrnpull.o(.text+0x2cdc):slrnpull.c: undefined reference to `slrn_string_nonascii'
gw32objs/slrnpull.o(.text+0x2e35):slrnpull.c: undefined reference to `Slrn_Display_Charset'
gw32objs/slrnpull.o(.text+0x2e58):slrnpull.c: undefined reference to `Slrn_Display_Charset'
gw32objs/slrnpull.o(.text+0x2ea8):slrnpull.c: undefined reference to `Slrn_Display_Charset'
gw32objs/slrnpull.o(.text+0x2eb7):slrnpull.c: undefined reference to `slrn_convert_substring'
gw32objs/slrnpull.o(.text+0x2f0b):slrnpull.c: undefined reference to `Slrn_Display_Charset'
d:\sbin\MinGW\mingw\bin\mingw32-make.exe: *** [slrnpull.exe] Error 1


-- 
newsgate666
Music: Nine Inch Nails - 01 March Of The Pigs [1994]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV