Re: Patches for slrn

Hi John,

"John E. Davis" <[email protected]> wrote:
> Jörg Sommer <[email protected]> wrote:
>>> However some systems require additional networking libraries that this
>>> check brings in.  For example on solaris the macro will pull in the
>>> socket and nsl libraries.  Without it, slrn will not compile.
>>
>> This sounds strange: Include the X libraries to get network support.
>> Isn't it better to include the network libraries directly? Are you sure
>> this check doesn't pull in some other unneeded dependencies on X
>> libraries?
>
> slrn has been using AC_PATH_XTRA since the 1990s and as far as I know,
> it has not caused a problem.

Okay. I've disabled the check with the configure option --without-x. I'm
happy with this solution.

> [...]
>>> This is not portable to all systems that slrn supports.  A more
>>> portable method is to use "%lu" and cast the size_t argument to an
>>> unsigned long.  Ten years ago I would have resisted using %u, because
>>> it was not supported by all systems that slrn ran on.
>>
>> And what do you think about an (ugly) configure check with a define?
>
> There is more too it than that.

I know.

> To properly deal with the changes to the gettext message strings that
> are used for translation, I will have to modifiy the code and change,
>
>     sprintf (buf, "%zu", sizeof(foo));
>     slrn_message(_("This has a format specifier %s"), buf);

Eecks. I thought gettext has support for private format specifier, but it
can only deal with the macros from inttypes.h. That's said.

It's alright for me to maintain this patch in the Debian package.

Bye, Jörg.
-- 
Mathematiker beim Kuchenessen (aus dem wahren Leben):
J: Du überlegst wohl, wie du das Stück optimal teilst?
K: Ja, ich wende gerade den Simplex‐Algorithmus darauf an.
C: Schau mal, da hast du schon vier Ecken.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/