Re: [bug] attributes stuff in options_menu.c broken

Urs Janßen <[email protected]> Wed, 5 Nov 2008 19:48:42 +0100
Newsgroups gmane.network.tin.devel
Message-ID <[email protected]>
On Wed, Nov 05, 2008 at 06:35:34PM +0100, Dennis Preiser wrote:
> In principle, we do most off the stuff read_attributes_files() does  
> then.

in general we should avoid "massiv" rereads of (config)-file(s), but as the
reread only happens if the menu is left either solution is ok with me.

>> you've missed some - and some of the missed options are 'problematic'
> That's why I didn't touched these options.

but it would make things much easyer if we harmonize the tinrc and
attributes vars first (which is a pain in some cases, e.g. post_proc_type /
post_process). and while beeing at that we should harmonize the the strings
used in the files as well. e.g.:

t_config.post_process -> t_config.post_process_type

t_attribute.post_proc_type -> t_attribute.post_process_type

constext txt_post_process_type -> constext txt_post_process_types (or
whatver, but not txt_post_process_type :-)

opttxt txt_post_process -> opttxt txt_post_process_type

check for 'post_process_type' "instead" of 'post_proc_type' in
attributes, but increase the attributes file version number and add an
update-function (like config.c:rc_update()).

urs
-- 
"Only whimps use tape backup: _real_ men just upload their important stuff
 on ftp, and let the rest of the world mirror it ;)" - Linus