acli:trn/master merged into LegalizeAdulthood:trn/master

Richard <legalize-aS9lmoZGLiVWk0Htik3J/[email protected]> Sun, 16 Apr 2023 23:19:59 -0600
Newsgroups gmane.network.trn.general
Organization multi-cellular, biological
Message-ID <[email protected]>
Hi Team,

Phew!  That took some effort.

Well, actually merging acli's master into my master was easy.  What
took some effort was rebasing my cmake branch onto the new master.

I still need to incorporate the tests that acli added (yay tests!).

Looking at the range of commits, I can see that acli has put quite a
bit of work into the various changes needed to support clean UTF-8
output.

So this is a good situation we're in here; acli's UTF-8 work has been
integrated, the patch for the old usenet dates (unix UTC timestamps)
has been incorporated.  Pdcurses and boost.asio have simplified the
support for Windows without having to write a bunch of Windows
specific code.

I do see some goofiness in the tests if I run them repeatedly or in a
shuffle order, so there is probably some state that isn't being reset
properly by the test fixtures.  Given the huge number of global
variables used by trn this isn't surprising.  Orchestrating that state
was done based on a 'best guess' basis since I am still learning the
various bits of code.  Still, we're in a good state and I've tried to
cover my changes with tests as best as possible in this legacy code
base.

Cheers,

-- Richard

-- 
"The Direct3D Graphics Pipeline" free book <http://tinyurl.com/d3d-pipeline>
             The Terminals Wiki <http://terminals-wiki.org>
     The Computer Graphics Museum <http://ComputerGraphicsMuseum.org>
  Legalize Adulthood! (my blog) <http://LegalizeAdulthood.wordpress.com>