Re: Possible bug in PkgVersion.pm - app builds fail

On 7/31/12 4:26 AM, Jonas Steverud wrote:
> Hello, I'm a long time fink user that thinks that he might have found an error in the PkgVersion.pm code.
> 
> Short story: on line 3914 the trailing newline is not removed from the output of xcode-select, so the resulting path strings contain this newline and the resulting scripts fails.
> 
> Longer story:
> 
> I ran fink selfupdate last weekend and when I tried to install emacs23-app (which I have not had installed previously) it fails (please see attached log). When I started to find out what went wrong I found that the generated script (attached as well) contained one newline too many. To cut a long story short I found out where this script where generated: In PkgVersion.pm when handling AppBundles on lines 3907 to 3917.
> 
> The offending line is 
> 		my $developer_dir=`xcode-select -print-path 2>/dev/null`;
> where the trailing new line is not removed from the output of xcode-select. I replaced that line with 
> 		my $developer_dir="/Developer";
> (which is the output of xcode-select) and tried to install emacs again, this time with complete success.
> 
> As far as I can tell this is a bug, and Google could not find any related discussions or bug reports. Neither could I find a better way of reporting this bug then email this address, which I hope is the correct receiver of this bug report.
> 
> Please see the attached log for Xcode version etc.
> 
> I know that I have an old Xcode and OS installation, but that shouldn't impact this line in the code. It is always a bad idea to depend on the output of another script and not wash it for unwanted output, I think this needs to be fixed regardless of my installation.
> 
> 
> 
> 

(Please don't attach files.  Having to unpack gzip archives and pasting
text back into messages is more extra work than your unpaid volunteers
care to deal with.)

Thanks for the report.

We just recently got rid of that "/Developer" because it doesn't exist
on Xcode 4.3 and later.  Unfortunately it looks like I missed a chomp()
to get rid of that newline.  So sue me.
-- 
Alexander Hansen, Ph.D.
Fink User Liaison
My package updates: http://finkakh.wordpress.com/

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
fink-core mailing list
[email protected]
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core