Re: emacs26-app

On 5/4/20 9:20 AM, Tomoaki Okayama wrote:
> Hi,
> 
> I created emacs26-app.info and emacs26-app.patch, which seem
> fine on macos 10.15.4. Not sure whether they work fine on 10.14
> or earlier, though.

Hi Tomoaki,

Can you submit this as a pull request in Github? It'll make discussion 
and tracking changes easier.
https://github.com/fink/fink-distributions/pulls

If you need git help, here's a quick primer on how to do it:
https://github.com/fink/fink-distributions/wiki/Submitting-new-or-updated-packages

Looking through your submission:
1) Can you add `SetCPPFLAGS: -MD` and then add a call to
"fink-package-precedence --depfile-ext='\.d' ." at the end of 
CompileScript? This will help you find missing dependencies. When I test 
built your submission, I got hits for glib2-dev, gtk+2-dev, imagemagick, 
and assorted image libraries. You'll either need to explicitly disable 
any of these that you don't want, or explicitly set (Build)Depends on 
them to get deterministic builds.

2) You run autogen.sh after patching configure and lib-src/Makefile.in. 
So those patches are overriden when autogen.sh is run and the files are 
re-generated. Is that on purpose? If so, please document it in 
DescPackaging since it's not the usual sequence.

3) It builds on 10.13/xcode10.1 and 10.15.4/xcode11.4.1. I don't use 
emacs, so I can't test anything besides saying it ran. Since this builds 
on 10.15.4, do you know why our current emacs26 fails to build on 
10.15.4/xcode11.4?
https://sourceforge.net/p/fink/mailman/message/36984532/

Hanspeter


_______________________________________________
Fink-devel mailing list
[email protected]
List archive:
https://sourceforge.net/p/fink/mailman/fink-devel
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-devel