Re: emacs26-app
Leigh Smith <[email protected]> Mon, 4 May 2020 14:52:43 -0400
| Newsgroups | gmane.os.apple.fink.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============4615494983407553062== Content-Type: multipart/alternative; boundary="Apple-Mail=_1C26FEEE-30A4-4FCE-9B65-EF2B35516B5E" --Apple-Mail=_1C26FEEE-30A4-4FCE-9B65-EF2B35516B5E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Once it=E2=80=99s up on GitHub as a PR, I=E2=80=99ll test it on 10.14 = FWIW. I was working on my own version, so this is really great work = Tomoaki! > On 4 May 2020, at 2:50 pm, Hanspeter Niederstrasser = <[email protected]> wrote: >=20 > On 5/4/20 9:20 AM, Tomoaki Okayama wrote: >> Hi, >> I created emacs26-app.info and emacs26-app.patch, which seem >> fine on macos 10.15.4. Not sure whether they work fine on 10.14 >> or earlier, though. >=20 > Hi Tomoaki, >=20 > Can you submit this as a pull request in Github? It'll make discussion = and tracking changes easier. > https://github.com/fink/fink-distributions/pulls >=20 > If you need git help, here's a quick primer on how to do it: > = https://github.com/fink/fink-distributions/wiki/Submitting-new-or-updated-= packages >=20 > Looking through your submission: > 1) Can you add `SetCPPFLAGS: -MD` and then add a call to > "fink-package-precedence --depfile-ext=3D'\.d' ." at the end of = CompileScript? This will help you find missing dependencies. When I test = built your submission, I got hits for glib2-dev, gtk+2-dev, imagemagick, = and assorted image libraries. You'll either need to explicitly disable = any of these that you don't want, or explicitly set (Build)Depends on = them to get deterministic builds. >=20 > 2) You run autogen.sh after patching configure and = lib-src/Makefile.in. So those patches are overriden when autogen.sh is = run and the files are re-generated. Is that on purpose? If so, please = document it in DescPackaging since it's not the usual sequence. >=20 > 3) It builds on 10.13/xcode10.1 and 10.15.4/xcode11.4.1. I don't use = emacs, so I can't test anything besides saying it ran. Since this builds = on 10.15.4, do you know why our current emacs26 fails to build on = 10.15.4/xcode11.4? > https://sourceforge.net/p/fink/mailman/message/36984532/ >=20 > Hanspeter >=20 >=20 > _______________________________________________ > Fink-devel mailing list > [email protected] > List archive: > https://sourceforge.net/p/fink/mailman/fink-devel > Subscription management: > https://lists.sourceforge.net/lists/listinfo/fink-devel Leigh -- Leigh M. Smith mailto:[email protected] http://www.leighsmith.com=20 --Apple-Mail=_1C26FEEE-30A4-4FCE-9B65-EF2B35516B5E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D"">Once = it=E2=80=99s up on GitHub as a PR, I=E2=80=99ll test it on 10.14 FWIW. I = was working on my own version, so this is really great work Tomoaki!<br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On 4 May 2020, at 2:50 pm, Hanspeter Niederstrasser <<a = href=3D"mailto:[email protected]" = class=3D"">[email protected]</a>> wrote:</div><br = class=3D"Apple-interchange-newline"><div class=3D""><div class=3D"">On = 5/4/20 9:20 AM, Tomoaki Okayama wrote:<br class=3D""><blockquote = type=3D"cite" class=3D"">Hi,<br class=3D"">I created <a = href=3D"http://emacs26-app.info" class=3D"">emacs26-app.info</a> and = emacs26-app.patch, which seem<br class=3D"">fine on macos 10.15.4. Not = sure whether they work fine on 10.14<br class=3D"">or earlier, = though.<br class=3D""></blockquote><br class=3D"">Hi Tomoaki,<br = class=3D""><br class=3D"">Can you submit this as a pull request in = Github? It'll make discussion and tracking changes easier.<br = class=3D""><a href=3D"https://github.com/fink/fink-distributions/pulls" = class=3D"">https://github.com/fink/fink-distributions/pulls</a><br = class=3D""><br class=3D"">If you need git help, here's a quick primer on = how to do it:<br = class=3D"">https://github.com/fink/fink-distributions/wiki/Submitting-new-= or-updated-packages<br class=3D""><br class=3D"">Looking through your = submission:<br class=3D"">1) Can you add `SetCPPFLAGS: -MD` and then add = a call to<br class=3D"">"fink-package-precedence --depfile-ext=3D'\.d' = ." at the end of CompileScript? This will help you find missing = dependencies. When I test built your submission, I got hits for = glib2-dev, gtk+2-dev, imagemagick, and assorted image libraries. You'll = either need to explicitly disable any of these that you don't want, or = explicitly set (Build)Depends on them to get deterministic builds.<br = class=3D""><br class=3D"">2) You run autogen.sh after patching configure = and lib-src/Makefile.in. So those patches are overriden when autogen.sh = is run and the files are re-generated. Is that on purpose? If so, please = document it in DescPackaging since it's not the usual sequence.<br = class=3D""><br class=3D"">3) It builds on 10.13/xcode10.1 and = 10.15.4/xcode11.4.1. I don't use emacs, so I can't test anything besides = saying it ran. Since this builds on 10.15.4, do you know why our current = emacs26 fails to build on 10.15.4/xcode11.4?<br = class=3D"">https://sourceforge.net/p/fink/mailman/message/36984532/<br = class=3D""><br class=3D"">Hanspeter<br class=3D""><br class=3D""><br = class=3D"">_______________________________________________<br = class=3D"">Fink-devel mailing list<br = class=3D"">[email protected]<br class=3D"">List = archive:<br = class=3D"">https://sourceforge.net/p/fink/mailman/fink-devel<br = class=3D"">Subscription management:<br = class=3D"">https://lists.sourceforge.net/lists/listinfo/fink-devel<br = class=3D""></div></div></blockquote></div><br class=3D""><div class=3D""> <div style=3D"color: rgb(0, 0, 0); font-family: Helvetica; font-size: = 12px; font-style: normal; font-variant: normal; font-weight: normal; = letter-spacing: normal; line-height: normal; orphans: 2; text-align: = -webkit-auto; text-indent: 0px; text-transform: none; white-space: = normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; margin: 0px; " class=3D""><br = class=3D"Apple-interchange-newline">Leigh</div><div style=3D"color: = rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: = normal; font-variant: normal; font-weight: normal; letter-spacing: = normal; line-height: normal; orphans: 2; text-align: -webkit-auto; = text-indent: 0px; text-transform: none; white-space: normal; widows: 2; = word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; margin: 0px; " class=3D"">--</div><div = style=3D"color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; = font-style: normal; font-variant: normal; font-weight: normal; = letter-spacing: normal; line-height: normal; orphans: 2; text-align: = -webkit-auto; text-indent: 0px; text-transform: none; white-space: = normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; margin: 0px; " class=3D"">Leigh M. = Smith</div><div style=3D"color: rgb(0, 0, 0); font-family: Helvetica; = font-size: 12px; font-style: normal; font-variant: normal; font-weight: = normal; letter-spacing: normal; line-height: normal; orphans: 2; = text-align: -webkit-auto; text-indent: 0px; text-transform: none; = white-space: normal; widows: 2; word-spacing: 0px; = -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; margin: = 0px; " class=3D""><a href=3D"mailto:[email protected]" = class=3D"">mailto:[email protected]</a></div><div style=3D"color: = rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: = normal; font-variant: normal; font-weight: normal; letter-spacing: = normal; line-height: normal; orphans: 2; text-align: -webkit-auto; = text-indent: 0px; text-transform: none; white-space: normal; widows: 2; = word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; margin: 0px; " class=3D""><a = href=3D"http://www.leighsmith.com" = class=3D"">http://www.leighsmith.com</a> </div><div style=3D"color: = rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: = normal; font-variant: normal; font-weight: normal; letter-spacing: = normal; line-height: normal; orphans: 2; text-align: -webkit-auto; = text-indent: 0px; text-transform: none; white-space: normal; widows: 2; = word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; margin: 0px; " class=3D""><br = class=3D""></div><br class=3D"Apple-interchange-newline" style=3D"color: = rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: = normal; font-variant: normal; font-weight: normal; letter-spacing: = normal; line-height: normal; orphans: 2; text-align: -webkit-auto; = text-indent: 0px; text-transform: none; white-space: normal; widows: 2; = word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; "><br class=3D"Apple-interchange-newline" = style=3D"color: rgb(0, 0, 0); font-family: Helvetica; font-style: = normal; font-variant: normal; font-weight: normal; letter-spacing: = normal; line-height: normal; orphans: 2; text-align: -webkit-auto; = text-indent: 0px; text-transform: none; white-space: normal; widows: 2; = word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; "> </div> <br class=3D""></body></html>= --Apple-Mail=_1C26FEEE-30A4-4FCE-9B65-EF2B35516B5E-- --===============4615494983407553062== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============4615494983407553062== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Fink-devel mailing list [email protected] List archive: https://sourceforge.net/p/fink/mailman/fink-devel Subscription management: https://lists.sourceforge.net/lists/listinfo/fink-devel --===============4615494983407553062==--