Re: git: 1dfcff294e44 - main - release: increase IMAGE_SIZE for arm, arm64, riscv [odd alignment for SBC images]

Ed Maste <[email protected]>
Newsgroups gmane.os.freebsd.devel.arm
Message-ID <CAPyFy2D1aBe8h4kq=RqCR2tkEiEXh_pHNEqaAnW7tk9-HxCmBQ@mail.gmail.com>
On Sun, 17 Jul 2022 at 13:08, Rodney W. Grimes
<[email protected]> wrote:

> Perhaps an assert for kern.geom.part.mbr.enforce_chs not
> being zero in /usr/src/release scripts is in order so that
> the builds blow up rather than produce BAD images.

This is a good interim step (before switching to mkimg).

Perhaps:

diff --git a/release/tools/arm.subr b/release/tools/arm.subr
index 77b708bca4a2..94e0ee89deaf 100644
--- a/release/tools/arm.subr
+++ b/release/tools/arm.subr
@@ -62,6 +62,10 @@ umount_loop() {
 }

 arm_create_disk() {
+       if [ $(sysctl -n kern.geom.part.mbr.enforce_chs) != 0 ]; then
+               return 1
+       fi
+
        # Create the target raw file and temporary work directory.
        chroot ${CHROOTDIR} gpart create -s ${PART_SCHEME} ${mddev}
        if [ "${PART_SCHEME}" = "GPT" ]; then
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.