Re: git: 1dfcff294e44 - main - release: increase IMAGE_SIZE for arm, arm64, riscv [odd alignment for SBC images]

Glen Barber <[email protected]> Tue, 19 Jul 2022 20:42:45 +0000

Newsgroups	gmane.os.freebsd.devel.arm
Message-ID	<[email protected]>

On Tue, Jul 19, 2022 at 04:35:36PM -0400, Ed Maste wrote:
> On Sun, 17 Jul 2022 at 13:08, Rodney W. Grimes
> <[email protected]> wrote:
> 
> > Perhaps an assert for kern.geom.part.mbr.enforce_chs not
> > being zero in /usr/src/release scripts is in order so that
> > the builds blow up rather than produce BAD images.
> 
> This is a good interim step (before switching to mkimg).
> 
> Perhaps:
> 
> diff --git a/release/tools/arm.subr b/release/tools/arm.subr
> index 77b708bca4a2..94e0ee89deaf 100644
> --- a/release/tools/arm.subr
> +++ b/release/tools/arm.subr
> @@ -62,6 +62,10 @@ umount_loop() {
>  }
> 
>  arm_create_disk() {
> +       if [ $(sysctl -n kern.geom.part.mbr.enforce_chs) != 0 ]; then
> +               return 1
> +       fi
> +
>         # Create the target raw file and temporary work directory.
>         chroot ${CHROOTDIR} gpart create -s ${PART_SCHEME} ${mddev}
>         if [ "${PART_SCHEME}" = "GPT" ]; then
> 

My concern with this is kern.geom.part.mbr.enforce_chs is always '1' on
the builders, which effectively means all arm builds will fail every
time.  I think we need to get to the actual root of the problem here,
versus applying band-aids to a shark bite.

Glen

signature.asc (application/pgp-signature, 833 B)