Re: Library __progname cleanups - commit candidate

On Wed, 27 Mar 2002, Mark Murray wrote:

> > > retrieving revision 1.3
> > > diff -u -d -r1.3 getprogname.c
> > > --- libc/gen/getprogname.c	1 Feb 2002 00:57:29 -0000	1.3
> > > +++ libc/gen/getprogname.c	26 Mar 2002 08:33:48 -0000
> > > @@ -3,10 +3,12 @@
> > >
> > >  #include <stdlib.h>
> >
> > This is missing includes of "namespace.h" and "un-namespace.h", except
> > you do things in a nonstandard way.  Similarly elsewhere.  Not so
> > similarly in err.c above (I limited the scopy of the namespace includes
> > too carefully there, so they don't already cover <stdlib.h>).
>
> You don't think this "standard way" could be documented somewhere, do you?

The logs for the commits that added it should be sufficient.  There are
hundreds of examples.

> > > -			snprintf(str, sizeof(str), "%s - Warning: Thread %p attempted to lock %p from %s (%d) was left locked from %s (%d)\n", __progname, curthread, lck, fname, lineno, lck->fname, lck->lineno);
> > > +			snprintf(str, sizeof(str), "%s - Warning: Thread %p attempted to lock %p from %s (%d) was left locked from %s (%d)\n", _getprogname(), curthread, lck, fname, lineno, lck->fname, lck->lineno);
> >
> > Disgustingly long line longer than before.
>
> I'd prefer to solve this with an appropriate indent(1).

FreeBSD's indent(1) doesn't understand long lines at all.

Bruce


To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message