Re: Library __progname cleanups - commit candidate
Mark Murray <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.audit |
|---|---|
| Message-ID | <[email protected]> |
> > > too carefully there, so they don't already cover <stdlib.h>). > > > > You don't think this "standard way" could be documented somewhere, do you? > > The logs for the commits that added it should be sufficient. There are > hundreds of examples. "Should be" != "Is". Grovelling out the right example is an exercise in futility, as for each example there is usually a counterexample. > > > > - snprintf(str, sizeof(str), "%s - Warning: Thread %p attempted to lock %p from %s (%d) was left locked from %s (%d)\n", __progname, curthread, lck, fname, lineno, lck->fname, lck->lineno); > > > > + snprintf(str, sizeof(str), "%s - Warning: Thread %p attempted to lock %p from %s (%d) was left locked from %s (%d)\n", _getprogname(), curthread, lck, fname, lineno, lck->fname, lck->lineno); > > > > > > Disgustingly long line longer than before. > > > > I'd prefer to solve this with an appropriate indent(1). > > FreeBSD's indent(1) doesn't understand long lines at all. FSF/GNU indent is much better, and large parts of it are still BSD licensed. I'm working on backporting those bits. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to [email protected] with "unsubscribe freebsd-audit" in the body of the message