Re: pccard re-attach after ACPI S1 resume

Hi John,

On Thu, Sep 12, 2002 at 01:25:05PM -0400, John Baldwin wrote:
> > +     sc->suspended = 0; /* XXX initialize, maybe not here */
> > +
> >       /*
> >        * this is here so that when socket_enable calls gettype, trt happens
> >        */
> 
> This part you don't need because softc's are zero'd when they are allocated.

Ok. But still I need it for the reason below.

> What if you just had pccard_resume() always call pccard_attach_card(self), 
> does that work?  

Then we do an attach on a slot where we know there isn't anything anyway.
That basicly doesn't make sense, and it also spits out all kind of ulgy
messages that we don't want/need.

> If not, you do have one bug, you should clear sc_suspended after
> the pccard_attach_card() in pccard_resume().

No, that's why I set it to zero again in pccard_attach_card(). (Which is
called for every slot that has sc->suspended==1)

Btw, is this problem specific to me or is just nobody using/reporting this?
It would seem like a generic problem.

Mark

-- 
Mark Santcroos				RIPE Network Coordination Centre
http://www.ripe.net/home/mark/		New Projects Group/TTM

To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-mobile" in the body of the message