Re: pccard re-attach after ACPI S1 resume
John Baldwin <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.mobile |
|---|---|
| Message-ID | <[email protected]> |
On 12-Sep-2002 Mark Santcroos wrote: > Hi John, > > On Thu, Sep 12, 2002 at 01:25:05PM -0400, John Baldwin wrote: >> > + sc->suspended = 0; /* XXX initialize, maybe not here */ >> > + >> > /* >> > * this is here so that when socket_enable calls gettype, trt happens >> > */ >> >> This part you don't need because softc's are zero'd when they are allocated. > > Ok. But still I need it for the reason below. > >> What if you just had pccard_resume() always call pccard_attach_card(self), >> does that work? > > Then we do an attach on a slot where we know there isn't anything anyway. > That basicly doesn't make sense, and it also spits out all kind of ulgy > messages that we don't want/need. We do a detach when we don't know if something is there in pccard_suspend(). :) Maybe pccard_attach_card() could take an argument to tell it to not whine if there is no card there. > Btw, is this problem specific to me or is just nobody using/reporting this? > It would seem like a generic problem. No, I see it too. I just don't suspend very often with pccards in my laptop. -- John Baldwin <[email protected]> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to [email protected] with "unsubscribe freebsd-mobile" in the body of the message