[Bug 297560] ftp/curl-impersonate: header files conflict with ftp/curl (installs into include/curl/, same as base curl port)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=297560

            Bug ID: 297560
           Summary: ftp/curl-impersonate: header files conflict with
                    ftp/curl (installs into include/curl/, same as base
                    curl port)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]
          Assignee: [email protected]
             Flags: maintainer-feedback?([email protected])

Created attachment 273801
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=273801&action=edit
install error

ftp/curl-impersonate installs its header files directly into
${PREFIX}/include/curl/ (curl.h, curlver.h, easy.h, etc. — see pkg-plist),
which is the exact same path used by the regular ftp/curl port. This makes
curl-impersonate impossible to install on any system that already has the
curl package installed (which is a very common baseline package), and also
blocks ftp/py-curl-cffi, which depends on curl-impersonate.

Steps to reproduce:
 # pkg info curl
 curl-8.21.0
 # cd /usr/ports/ftp/py-curl-cffi && make
 ...
 ===>  Installing for curl-impersonate-2.0.0
 pkg-static: curl-impersonate-2.0.0 conflicts with curl-8.21.0
 (installs files into the same place). Problematic file:
 /usr/local/include/curl/curl.h
 *** Error code 1

Environment:
 FreeBSD 14.4-RELEASE-p5 amd64
 curl-impersonate 2.0.0 (ftp/curl-impersonate)
 curl 8.21.0 (ftp/curl)

Suggested fix:
An unofficial FreeBSD port of curl-impersonate
(github.com/trombik/freebsd-ports-curl-impersonate) already solves this
exact problem: its patch-Makefile.in installs the headers into
${PREFIX}/include/curl-impersonate/ instead of ${PREFIX}/include/curl/,
avoiding the conflict entirely:

 -     cp -R include/curl "$(DESTDIR)@includedir@"
 +     rm include/curl/Makefile*
 +     cp -R include/curl "$(DESTDIR)@includedir@/curl-impersonate"

Applying the same approach (installing to a curl-impersonate-specific
subdirectory, and updating any build flags/pkg-config that reference the
include path accordingly) in the official ftp/curl-impersonate port would
resolve the conflict without requiring users to remove their existing curl
installation.

-- 
You are receiving this mail because:
You are the assignee for the bug.