[Bug 276492] [NEW PORT] editors/sciteco: Scintilla-based Text Editor and Corrector

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276492

--- Comment #11 from Robin Haberkorn <[email protected]> ---
Hello Rodrigo,

thanks for picking this up.

I don't quite understand why we need to copy ${FILESDIR}/xvfb-run.sh.in to
${WRKDIR}/xvfb-run.sh in order to execute it. SCRIPTDIR appears to be the right
place ("A directory containing any auxiliary scripts" according to
Mk/bsd.port.mk) and we can execute scripts from there as well. ${SH} should be
added though, that's true. So what speaks against

MAKE_CMD=${SH} ${SCRIPTDIR}/xvfb-run.sh ${GMAKE}

I have nothing against the portfmt formatting.

If you agree and that's the only thing speaking against the merge, I will
update the patch and bump the version to v2.2.0.

Best regards,
Robin

-- 
You are receiving this mail because:
You are on the CC list for the bug.