Re: port-sparc64/60428 (NetBSD 11.99.6/sparc64 panics on USB insertion)

The following reply was made to PR port-sparc64/60428; it has been noted by GNATS.

From: Julian Coleman <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected],
	[email protected], [email protected]
Subject: Re: port-sparc64/60428 (NetBSD 11.99.6/sparc64 panics on USB
 insertion)
Date: Thu, 9 Jul 2026 07:01:15 +0200

 Hi,
 
 >  Or, better:
 >  
 >  --- src/sys/arch/sparc64/sparc64/autoconf.c
 >  +++ src/sys/arch/sparc64/sparc64/autoconf.c
 >  @@ -1235,6 +1235,8 @@
 >   		 * controller's devhandle.  Hoist it up one more so
 >   		 * that busdev points at the controller.
 >   		 */
 >  +		if (devhandle_type(devhandle) != DEVHANDLE_TYPE_OF)
 >  +			return;
 >   		busdev = device_parent(busdev);
 >   		devhandle = device_handle(busdev);
 >   		KASSERT(devhandle_type(devhandle) == DEVHANDLE_TYPE_OF);
 
 Before r1.230, we always set ofnode [*], so I wonder if we should continue
 to do that.
 
 We also now have the same KASSERT in the wd case on line 1276, so that
 needs the same treatment.  The one for FC-AL is probably OK, although I
 would be tempted to change all 3 to plain return for consistency.
 
 Regards,
 
 Julian
 
 [*] https://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/sparc64/sparc64/autoconf.c.diff?r1=1.229;r2=1.230;f=h
 --