Re: port-sparc64/60428 (NetBSD 11.99.6/sparc64 panics on USB insertion)
Julian Coleman <[email protected]>
| Newsgroups | gmane.os.netbsd.bugs |
|---|---|
| Message-ID | <ak8u1DL2-XH0UNJV@morava> |
Hi, > Before r1.230, we always set ofnode [*], so I wonder if we should continue > to do that. Looking slightly more deeply [#], devhandle_to_of() has the same KASSERT, so we must return before we call it. > We also now have the same KASSERT in the wd case on line 1276, so that > needs the same treatment. The one for FC-AL is probably OK, although I > would be tempted to change all 3 to plain return for consistency. Regards, Julian [#] https://nxr.netbsd.org/xref/src/sys/dev/ofw/ofw_subr.c#119 --