Re: wip/dcc: pkglint output

On Wed, Mar 25, 2009 at 02:24:10PM +0100, Thomas Klausner wrote:
> On Wed, Mar 25, 2009 at 11:09:58AM +0100, Petar Bogdanovic wrote:
> > I just did a `pkglint -Wall' on wip/dcc and do not fully understand some
> > of the warnings. Here is an initial attempt:
> > 
> 
> pkglint --explain helps...

Oops, sorry!


> > 	> WARN: Makefile:29: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
> > 	> WARN: Makefile:30: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
> > 
> > What is BUILD_DEFS and do I really need it? Also: Why is VARBASE
> > `user-defined'?
> 
> BUILD_DEFS are the variables that are exported to the binary
> package. You should add VARBASE to it so that the value of VARBASE
> during building can be checked in the binary package.
> 
> VARBASE can be set in /etc/mk.conf and thus differ between the build
> host and the install host.

Hm, shouldn't the most variables be in BUILD_DEFS then?


> > 	> WARN: Makefile:150: The shell command "${SED}" should not be used in the install phase.
> > 
> > I use `${SED}' in INSTALL. Why shouldn't I use it?
> 
> WARN: Makefile:150: The shell command "${SED}" should not be used in
> the install phase.
> 
>         In the install phase, the only thing that should be done is to
>         install the prepared files to their final location. The file's
>         contents should not be changed anymore.

Ok, I could put the `offending' line (where I try to insert some paths)
into pre-install. Or would an own target be better?



   Petar Bogdanovic




------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com