Re: wip/dcc: pkglint output

On Wed, Mar 25, 2009 at 09:26:04AM -0400, Greg Troxel wrote:
> 
> > 	> WARN: Makefile:29: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
> > 	> WARN: Makefile:30: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
> >
> > What is BUILD_DEFS and do I really need it? Also: Why is VARBASE
> > `user-defined'?
> 
> Maybe due to missing bsd.prefs.mk.

I added bsd.prefs.mk but pkglint still reports it.


> BUILD_DEFS is a list of variables that can affect the build; they are
> recorded in the pkg control files.

The `build'? I got the impression from Thomas' message, that it rather
has something to do with the subsequent installation of binary packages,
since the variables on {build,install}-hosts may differ..


> > 	> WARN: Makefile:150: The shell command "${SED}" should not be used in the install phase.
> >
> > I use `${SED}' in INSTALL. Why shouldn't I use it?
> 
> Because that's build, not install.  install should just install.

Right, makes sense.



   Petar Bogdanovic




------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com