mplayer for X11_TYPE != "native"

Makoto Fujiwara <[email protected]>
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.general
Message-ID <yfm39veuqqi.wl%[email protected]>
I am using modular xorg and I have following line 
in /etc/mk.conf

X11_TYPE=       modular

Then I type make at wip/mplayer
--------
modena@makoto 00:07:43/100721(..wip/mplayer)% make
WARNING: [bsd.prefs.mk] The package mplayer-20100721nb20100720 is missing DESTDIR support.
WARNING: [license.mk] Every package should define a LICENSE.
ERROR: This package has set PKG_FAIL_REASON:
ERROR: Do not include x11.buildlink3.mk for X11_TYPE != "native".
*** Error code 1
Stop.
--------

Then I have applied attached patch.
Is this the right thing to do ?
Thank you,
---
Makoto Fujiwara, 
Chiba, Japan, Narita Airport and Disneyland prefecture.

Index: mplayer-share/Makefile.depends
===================================================================
RCS file: /cvsroot/pkgsrc-wip/wip/mplayer-share/Makefile.depends,v
retrieving revision 1.2
diff -u -r1.2 Makefile.depends
--- mplayer-share/Makefile.depends	30 Jan 2006 17:22:58 -0000	1.2
+++ mplayer-share/Makefile.depends	20 Jul 2010 15:11:01 -0000
@@ -9,4 +9,6 @@
 .  include "../../devel/binutils/buildlink3.mk"
 .endif
 .include "../../converters/libiconv/buildlink3.mk"
+.if ${X11_TYPE} == "native"
 .include "../../mk/x11.buildlink3.mk"
+.endif

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.