Re: collectd added

On Fri, Aug 07, 2009 at 11:45:15PM -0400, matthew sporleder wrote:
> > bsd.prefs.mk before options.mk is not necessary.
> > I've seen this more often lately, I wonder why?
> 
> I think I remember having issues when the order was different.

What happens if you just remove the bsd.prefs.mk inclusion? I only
remember needing it when checking for OPSYS, and you don't do that
here.

> I fixed the ERROR from pkglint about missing the # $NetBSD$, but I
> really don't understand the warnings:
> WARN: options.mk:5: Unknown option "rrdtool".
> WARN: options.mk:5: Unknown option "libstatgrab".
> WARN: options.mk:6: Unknown option "rrdtool".
> WARN: options.mk:6: Unknown option "libstatgrab".
> 
> Why doesn't it warn about curl or snmp?  I think they're all defined the same.

This means that the strings are not defined in
mk/defaults/options.description. Not much you can do about that, it
should just be fixed when the package is imported.

"pkglint --explain" explains it, btw.

> > Why does the package need libltdl?
> 
> I think url2pkg put it there.

Hm, ok.

> > I have PLIST trouble on 5.99.15/amd64:
> > => Checking file-check results for collectd-4.7.2
> > ERROR: ************************************************************
> > ERROR: The following files are in /usr/pkg but not in the PLIST:
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/apache.a
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/apache.la
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/apache.so
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/ascent.a
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/ascent.la
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/ascent.so
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/bind.a
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/bind.la
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/bind.so
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/curl.a
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/curl.la
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/curl.so
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/disk.a
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/disk.la
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/disk.so
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/nginx.a
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/nginx.la
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/nginx.so
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/rrdtool.a
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/rrdtool.la
> > ERROR:         /scratch/wip/collectd/work/.destdir/usr/pkg/lib/collectd/rrdtool.so
> > *** Error code 1
> 
> Some of those files come from the options.  Is there a good way to
> append to the PLIST from an option?

There are two ways -- using PLIST_SRC and having multiple PLIST files,
or probably better, using PLIST_VARS.

E.g.:
In options.mk:
PLIST_VARS+=	myoption
.if !empty(PKG_OPTIONS:Mmyoption)
PLIST.myoption=	yes
.endif

In PLIST:
${PLIST.myoption}path/to/additional/file

> > What is the question you have about config files?
> 
> I think I got that taken care of.

Great :)
 Thomas

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july