Re: Imported wip/libmicro - Review

Jean-Yves Migeon <[email protected]>
Newsgroups gmane.os.netbsd.devel.packages,gmane.os.netbsd.devel.pkgsrc.wip.review
Organization Free.fr
Message-ID <ef79f90a666b63404c399072aa82a9eb@localhost>
On Tue, 17 Nov 2009 16:46:37 +0300, Aleksej Saushev <[email protected]> wrote:
> Jean-Yves Migeon <[email protected]> writes:
> 
>> On Tue, 17 Nov 2009 13:03:21 +0100, Thomas Klausner
>> <[email protected]> wrote:
>>> On Sun, Nov 15, 2009 at 09:59:09PM +0100, Jean-Yves Migeon wrote:
>>>> I just imported libmicro into WIP, and would like you to review it.
>>> 
>>> Doesn't package with USE_DESTDIR=yes on 5.99.22/amd64:
>>
>> Alright, same player, shoot again -
>>
>> Would it be acceptable to add a variable like ${HARDWARE_ARCH} that
>> expands
>> to `uname -m` (or equivalent, depending on the supported OS) in pkgsrc?
>>
>> I am not quite certain that having such things in the Makefile:
>>
>> INSTALLATION_DIRS+= libexec/libmicro/bin-`uname -m`
>>
>> will work as expected, and providing a PLIST for each MACHINE_ARCH seems
>> overkill to me.
>>
>> Comments?
> 
> Why not patch it to install under "libexec/libmicro/bin" instead?

(moving this discussion to tech-pkg, where it belongs)

Under amd64, you could have bin-i386 and bin-amd64 directories.

I can always patch around all occurences of `uname -m` and replace them
with `uname -p`, but this makes me feel as I am patching to circumvent a
limitation.

More generally: you could have an architecture with multiple variants
(sparc => sun4m, sun4u, sun4v, ...), and I'd like to know if there is a
possibility to make such a distinction with pkgsrc.

Cheers,

-- 
Jean-Yves Migeon
[email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.