Re: Imported wip/libmicro - Review
Iain Hibbert <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.packages,gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 17 Nov 2009, Jean-Yves Migeon wrote: > > On Tue, 17 Nov 2009 16:46:37 +0300, Aleksej Saushev <[email protected]> wrote: > > Jean-Yves Migeon <[email protected]> writes: > > > >> On Tue, 17 Nov 2009 13:03:21 +0100, Thomas Klausner > >> <[email protected]> wrote: > >>> On Sun, Nov 15, 2009 at 09:59:09PM +0100, Jean-Yves Migeon wrote: > >>>> I just imported libmicro into WIP, and would like you to review it. > >>> > >>> Doesn't package with USE_DESTDIR=yes on 5.99.22/amd64: > >> > >> Alright, same player, shoot again - > >> > >> Would it be acceptable to add a variable like ${HARDWARE_ARCH} that > >> expands > >> to `uname -m` (or equivalent, depending on the supported OS) in pkgsrc? > >> > >> I am not quite certain that having such things in the Makefile: > >> > >> INSTALLATION_DIRS+= libexec/libmicro/bin-`uname -m` > >> > >> will work as expected, and providing a PLIST for each MACHINE_ARCH seems > >> overkill to me. you could provide a LIBMICRO_BINDIR as a PLIST substitution var, that way the PLIST contains ${LIBMICRO_BINDIR}/blah and is automatically adjusted for this. iain