Re: Please review wip/xvkbd
"OBATA Akio" <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
Hi, On Tue, 31 Aug 2010 04:42:27 +0900, Ryo ONODERA <[email protected]> wrote: > Hi, > > I have created wip/xvkbd package. > xvkbd is simple on-screen keyboard software. > > Plaese review this package. For man page handling, no need post-install target. It depend on platforms whether man and/or cat will be installed or not. (see mk/platform/*.mk) You can use ${IMAKE_MANDIR}/foo.${IMAKE_MAN_SUFFIX} in PLIST. There are some missing buildlink. In Imakefile, XTEST is defined, so xtest related packages should be buildlinked. If xaw option is enabled, x11/libXaw must be buildlinked. And you may include mk/xaw.buildlink3.mk and switch condition in Imakefile with XAW_TYPE. -- OBATA Akio / [email protected] ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd