Re: Please review wip/xvkbd
Ryo ONODERA <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
Thanks for your review. From: "OBATA Akio" <[email protected]> Subject: Re: Please review wip/xvkbd Date: Tue, 31 Aug 2010 11:13:44 +0900 > For man page handling, no need post-install target. > It depend on platforms whether man and/or cat will be installed or not. > (see mk/platform/*.mk) > You can use ${IMAKE_MANDIR}/foo.${IMAKE_MAN_SUFFIX} in PLIST. I understood this. > There are some missing buildlink. > In Imakefile, XTEST is defined, so xtest related packages should be buildlinked. > If xaw option is enabled, x11/libXaw must be buildlinked. > And you may include mk/xaw.buildlink3.mk and switch condition in Imakefile > with XAW_TYPE. I added missing buildlinks. But I cannot usage of XAW_TYPE. Do you know good example? -- Ryo ONODERA // [email protected] PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3 ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd