Re: Please review wip/mypaint

"OBATA Akio" <[email protected]>
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <[email protected]>
Hi,

On Sun, 19 Dec 2010 13:41:14 +0900, Ryo ONODERA <[email protected]> wrote:

> Please review again.

No need both USE_TOOLS and DEPENDS for bash.

Using pkg-config and msgfmt tools to build, and you should invoke scons with
${SETENV} ${MAKE_ENV}.

Probably, localedir should not be hard-coded in SConstruct as share/locale,
replaced with ${PKGLOCALEDIR}/locale and USE_PKGLOCALEDIR=yes instead.

-- 
OBATA Akio / [email protected]

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.