Re: Please review wip/mypaint
Ryo ONODERA <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
Hi, From: "OBATA Akio" <[email protected]>, Date: Sun, 19 Dec 2010 16:19:11 +0900 >> Please review again. > > No need both USE_TOOLS and DEPENDS for bash. > > Using pkg-config and msgfmt tools to build, and you should invoke > scons with > ${SETENV} ${MAKE_ENV}. > > Probably, localedir should not be hard-coded in SConstruct as > share/locale, > replaced with ${PKGLOCALEDIR}/locale and USE_PKGLOCALEDIR=yes instead. Thank you for review. Is USE_PKGLOCALEDIR=yes really needed here? I do not need replacement mechanism defined in pkgsrc/mk/configure/replace-localedir.mk. -- Ryo ONODERA // [email protected] PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3 ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d