Re: please review wip/cacti-spine

----- Mail original -----
> Hi,
> 
> On Mon, 29 Jul 2013 16:48:22 +0900, Nils Ratusznik
> <[email protected]> wrote:
> 
> >> > DISTFILES=              ${DISTNAME}${EXTRACT_SUFX}
> >>
> >> You can use ${DEFAULT_DISTFILE} instead.
> >
> > It breaks the build. This looks linked to the manpage and its
> > patch.
> 
> Oh, sorry for my mess, it should be ${DEFAULT_DISTFILES}.
> 
> >> > DISTFILES+=             spine.1.gz
> >> > SITES.spine.1.gz=       \
> >> >        http://manpages.ubuntu.com/manpages.gz/precise/man1/
> >>
> >> Is it useful for other tha Ubuntu?
> >> We are not neither Debian nor Ubuntu,
> >> so man pages for all commands are not required.
> >
> > I added this manpage after a pkglint run. Since there is no man
> > page in spine's archive, I took the manpage where it is.
> > Should I remove the man page and ignore future messages from
> > pkglint about it ?
> 
> It is harmless warnings, so please ignore it if manpages are not
> provided by upstream.
> (for example, category mismatch should be fixed, i.e. bin/command &
> man/man8/command.8)
> 
> >> > USE_TOOLS+=     autoconf autoheader automake aclocal
> >>
> >> I cannot find where such auto tools are used.
> >>
> >> > BUILD_DEPENDS+= automake-[0-9]*:../../devel/automake
> >>
> >> It will not be required, already in USE_TOOLS.
> >
> > I removed these 2 lines from the Makefile, and the package still
> > builds :-)
> >
> > Thank you very much for your review !
> 
> Thanks for your packaging!

Hi,

everything should be corrected now.

Regards,
--
Nils

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk