Re: Please review fluxter

Min Sik Kim <[email protected]>
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <[email protected]>
On Feb 12, 2006, at 12:36 PM, Michael-John Turner wrote:

> Hi all,
>
> I've just committed fluxter, a pager application for Fluxbox.  
> Please review
> and let me know what you think. I've tested it on NetBSD/sparc64 - 
> current
> and it seems to build, install, uninstall, etc fine and pkglint has no
> complaints.

- The correct variable name is "USE_LANGUAGES", not "USE_LANGUAGE".
- bsd.prefs.mk included in Makefile doesn't seem to be necessary.
- Shouldn't this package depend on wm/fluxbox?

Regards,
Min Sik Kim



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.