Re: Please review fluxter

Michael-John Turner <[email protected]>
Newsgroups gmane.os.netbsd.devel.pkgsrc.wip.review
Message-ID <[email protected]>
On Mon, Mar 20, 2006 at 09:24:09AM -0800, Min Sik Kim wrote:
> - The correct variable name is "USE_LANGUAGES", not "USE_LANGUAGE".
Fixed

> - bsd.prefs.mk included in Makefile doesn't seem to be necessary.
Fixed

> - Shouldn't this package depend on wm/fluxbox?

AFAIK it doesn't require fluxbox (in much the same way as wm/bbpager works
with both blackbox and fluxbox and a number of window managers). I've left
out the dependency for this reason.

Thanks for the suggestions - I've committed the changes.

-mj
-- 
Michael-John Turner | http://weblogs.turner.org.za/mj/
[email protected]    | Open Source in WC ZA - http://www.clug.org.za/


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.