Re: Removing __BROKEN_CONFIG_UNIT_USAGE

Jachym Holecek <[email protected]> Mon, 16 Jul 2007 16:53:09 +0200

Newsgroups	gmane.os.netbsd.ports.sun3,gmane.os.netbsd.devel.kernel
Message-ID	<20070716145309.GA1813@hanele>

# Izumi Tsutsui 2007-07-16:
> [email protected] wrote:
> 
> > Attached is a patch that should DTRT and allow us to remove the
> > __BROKEN_CONFIG_UNIT_USAGE tests in subr_autoconf.c.
> > 
> > My understanding of the sun3 code is that it used it to make sure the
> > xd and xy drives had the correct numbers, while still having a wildcard
> > instance in the config file, which is not only wrong but confusing.
> 
> I have not checked your patch closely, but
> arch/sun3/sun3{,x}/vme.c also have broken cf_unit usage.

A quick grep through sun3 configs shows vme only ever has wired instances,
so it would seem it's not broken in the __BROKEN_CONFIG_UNIT_USAGE sense.

	-- Jachym