Re: Removing __BROKEN_CONFIG_UNIT_USAGE

On Mon, Jul 16, 2007 at 04:53:09PM +0200, Jachym Holecek wrote:
> # Izumi Tsutsui 2007-07-16:
> > [email protected] wrote:
> > 
> > > Attached is a patch that should DTRT and allow us to remove the
> > > __BROKEN_CONFIG_UNIT_USAGE tests in subr_autoconf.c.
> > > 
> > > My understanding of the sun3 code is that it used it to make sure the
> > > xd and xy drives had the correct numbers, while still having a wildcard
> > > instance in the config file, which is not only wrong but confusing.
> > 
> > I have not checked your patch closely, but
> > arch/sun3/sun3{,x}/vme.c also have broken cf_unit usage.
> 
> A quick grep through sun3 configs shows vme only ever has wired instances,
> so it would seem it's not broken in the __BROKEN_CONFIG_UNIT_USAGE sense.

Exactly.

Yes, sun3 still relies on cf_unit to carry information, but it's not
alone in that respect.  As long as that kind of abuse is limited to
wired instances, it's ok.

-- 
Quentin Garnier - [email protected] - [email protected]
"You could have made it, spitting out benchmarks
Owe it to yourself not to fail"
Amplifico, Spitting Out Benchmarks, Hometakes Vol. 2, 2005.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (NetBSD)

iQEVAwUBRpuOetgoQloHrPnoAQI0egf+O1kCoHZmLZNtI+9KZX4iu0g3froDRPdN
pRiVXIvJ7fR3SCvBkNjbWCFlO4qhbGXfl9+lOynfga7oGdTTM4m+6+OZmBz1MRTG
iReodmuO+yQ6ms0nCPMoT/y4Qu1Cb5BfECkBoXWxU14J8MZSQo8DizAyWZCN53js
UpPt4jHfeUA4jmsiHqWr7Ii4rPx7mSVY67EQ6BwFpzT6MCH6Rq0UQ8ke1lZqacjQ
gzdIMkcgMp2W0mHRdcCfvLOpFWXxTKf62s1T4Qq/7o04mi73Ub/pVCm6SxKEE0TH
PrPCZ6/THYzu1H3+X9g6AxM5reQA2wDLyIGYdXDly69Lh8txuPWCyQ==
=TXgx
-----END PGP SIGNATURE-----