Re: [ros-diffs] [reactos] 01/01: [COMCTL32] Addendum to last commit (#3674) CORE-17199

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============4750415996233763819==
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="eRMHay8ou57Y9nvWgBOID32o5xBWlFHzI"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--eRMHay8ou57Y9nvWgBOID32o5xBWlFHzI
Content-Type: multipart/mixed; boundary="yxm1h5aVqYQWeEAGYtezR0Z2Awrxv1vzH";
 protected-headers="v1"
From: Colin Finck <[email protected]>
Reply-To: 'ReactOS Development List' <[email protected]>
To: 'ReactOS Development List' <[email protected]>,
 Joachim Henze <[email protected]>
Message-ID: <05fab3d2-7dbe-a1ae-644c-468ab26047d6-td3rRX5TIkhAfugRpC6u6w@public.gmane.org>
Subject: Re: [ros-diffs] [reactos] 01/01: [COMCTL32] Addendum to last commit
 (#3674) CORE-17199

--yxm1h5aVqYQWeEAGYtezR0Z2Awrxv1vzH
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Joachim Henze wrote:
> commit adee5ca255b7ed21f359ca8c1ca06bd44db90dcf
> Author:     Joachim Henze <Joachim.Henze at reactos.org>
> AuthorDate: Mon Jun 28 02:05:56 2021 +0200
> Commit:     Joachim Henze <Joachim.Henze at reactos.org>
> CommitDate: Mon Jun 28 02:05:56 2021 +0200
>=20
>     [COMCTL32] Addendum to last commit (#3674) CORE-17199
>    =20
>     Keep that section like we had it to
>     support compilation on VS2010.
>     It does still work like that.
>    =20
> [...]
>=20
> diff --git a/dll/win32/comctl32/datetime.c b/dll/win32/comctl32/datetim=
e.c
> index 71bb3d238b0..51e58fc71f1 100644
> --- a/dll/win32/comctl32/datetime.c
> +++ b/dll/win32/comctl32/datetime.c
> @@ -130,8 +130,13 @@ static const WCHAR allowedformatchars[] =3D L"dhHm=
MstyX";
>  static const int maxrepetition [] =3D {4,2,2,2,4,2,2,4,-1};
> =20
>  /* valid date limits */
> +#ifndef __REACTOS__
>  static const SYSTEMTIME max_allowed_date =3D { .wYear =3D 9999, .wMont=
h =3D 12, .wDayOfWeek =3D 0, .wDay =3D 31 };
>  static const SYSTEMTIME min_allowed_date =3D { .wYear =3D 1752, .wMont=
h =3D 9, .wDayOfWeek =3D 0, .wDay =3D 14 };
> +#else
> +static const SYSTEMTIME max_allowed_date =3D { /*.wYear =3D*/ 9999, /*=
=2EwMonth =3D*/ 12, /*.wDayOfWeek =3D*/ 0, /*.wDay =3D*/ 31 };
> +static const SYSTEMTIME min_allowed_date =3D { /*.wYear =3D*/ 1752, /*=
=2EwMonth =3D*/ 9, /*.wDayOfWeek =3D*/ 0, /*.wDay =3D*/ 14 };
> +#endif

This adds an unnecessary ReactOS-specific diff to a file that was=20
perfectly in sync with Wine 6.0 before, just for supporting an old=20
compiler that has not only been abandoned by us, but obviously also=20
upstream.

Being able to source this file unmodified (and eventually sourcing all=20
of comctl32 automatically via a Git submodule/subpath/repo xml file)=20
beats any such hack.
I therefore call for a revert.

Even worse than all of that, this commit has been silently sneaked on=20
top of a PR without any review!
Joachim, you love to criticize the instability of the master branch, yet =

continue to ignore basic development practices we have established.

And this isn't happening for the first time. Another example is=20
https://github.com/reactos/reactos/commit/889eab78ca7c0f17a2ada9ff20de580=
7a293cdfe=20
where you disable sanity checks and create a diff to upstream. All=20
without reviews and all just for your private goal of reducing the=20
binary size of debug builds, something that is not important at the=20
current stage of ReactOS.

I would love to see PRs for your ideas, and then we can discuss=20
everything that hasn't been decided before (i.e. not VS2010 support again=
).
But if this doesn't stop, I have no chance other than removing your push =

access to the GitHub repo, as everything else would mean condoning that=20
uncooperative behavior.


Best regards,

Colin


--yxm1h5aVqYQWeEAGYtezR0Z2Awrxv1vzH--

--eRMHay8ou57Y9nvWgBOID32o5xBWlFHzI
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsF5BAABCAAjFiEENLXXTejc76VQ9g3AG6dOcEVroakFAmDiIzEFAwAAAAAACgkQG6dOcEVroalp
iQ//RcoIEupgj4b3RHj9skVls69XWAb1tmEmobKi36mh1Xrn13aRsHBQmE/E9nwB/1rOiJYyhTZd
LihJQeHoerAGAkyx77Iq3lhB+bgqcH339PFFKNn/hg44Wk1jxXxY9BA0ZLkb63vYvWq0gX28GXeD
qNXi7/buqKnSrivSAvU/wAPx+rdsoGQ3VKHC35EsbWsMkFI5LRxkpHMOz8AU1zr7eSboyRvlBHmk
GHy02BqfafGNPGweomGEQWCTu0cFvaqFyawMAsCVYlmGyTD+3UahFxiSThlje9FNsHoUhIIhaGz1
yk7/V6Jk/A9kMP9ei7f1nFapV4OOpsWGplaNyQV2/cHr9FOtPnK1IIhyB/S2tMMk703JuE3OFn/4
bIZbNgKXvZ3e6akvPlFjuBuPjYzNQEsexqnfKs/F42N1J6XhhVg7ToPwNSszFHs9ksMX7aKw7Dmx
tnkncM50c85w7Il4FKsKNMWycvA99aK0YBzQARYiIyVqOvYjVmTGnkcxr0Amgdg40jariGo4rMC8
4VKVCN9Aka87SRv7iU8MSf2tzeN1ylg2bhr1pLuqQkz0+dqRaqIGAuaiYc+r93km9vhg0bcJaIM/
HoxMRoQaKUKf50GqOP342YwCeAwNSXJmPgxh/RRCzqAfGxm/XeYgL/mzoHsKGuQzxeSlWNF3qtYt
coQ=
=weNB
-----END PGP SIGNATURE-----

--eRMHay8ou57Y9nvWgBOID32o5xBWlFHzI--


--===============4750415996233763819==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Ros-dev mailing list
[email protected]
http://reactos.org/mailman/listinfo/ros-dev

--===============4750415996233763819==--