Re: [Rock-dev] [PATCH] RTT: Added way to disable exception catching

Hi,

On Tue, Oct 22, 2013 at 3:34 PM, Sylvain Joyeux <[email protected]> wrote:
> @Peter: could you have a look ? There are a few things I already
> mentioned to Matthias (e.g. that the static variable does not work).

Why doesn't it, it's only used in the local compilation unit and not
in headers ?

>
> For simplicity sake, I would personally remove the CMake option, what do
> you think ?

agreed.

>
> He also needs a file into which to put the #define and all, he picked
> Config.hpp but I find that not so-satisfactory. Any idea there ?

move it into rtt/impl and make sure that no public header includes
it... it's subject to name clashing.
maybe name it rtt/impl/CatchConfig.h ?

Also, the patch is full of trailing whitespace... please apply the
final version with whitespace squelching.

Peter

>
> Sylvain
> _______________________________________________
> Rock-dev mailing list
> [email protected]
> http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
-- 
Orocos-Dev mailing list
[email protected]
http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev