Re: [Rock-dev] [PATCH] RTT: Added way to disable exception catching
Sylvain Joyeux <[email protected]>
| Newsgroups | gmane.science.robotics.orocos.devel |
|---|---|
| Message-ID | <[email protected]> |
On 10/23/2013 10:14 AM, Peter Soetens wrote: > Hi, > > On Tue, Oct 22, 2013 at 3:34 PM, Sylvain Joyeux <[email protected]> wrote: >> @Peter: could you have a look ? There are a few things I already >> mentioned to Matthias (e.g. that the static variable does not work). > Why doesn't it, it's only used in the local compilation unit and not > in headers ? My issue with it is that it cannot then be set from within the C++ API (only from the runtime environment) >> He also needs a file into which to put the #define and all, he picked >> Config.hpp but I find that not so-satisfactory. Any idea there ? > move it into rtt/impl and make sure that no public header includes > it... it's subject to name clashing. > maybe name it rtt/impl/CatchConfig.h ? That sounds good. > Also, the patch is full of trailing whitespace... please apply the > final version with whitespace squelching. Agreed. -- Sylvain Joyeux (Dr.Ing.) Senior Researcher Space & Security Robotics Underwater Robotics !!! Achtung, neue Telefonnummer!!! Standort Bremen: DFKI GmbH Robotics Innovation Center Robert-Hooke-Straße 5 28359 Bremen, Germany Phone: +49 (0)421 178-454136 Fax: +49 (0)421 218-454150 E-Mail: [email protected] Weitere Informationen: http://www.dfki.de/robotik ----------------------------------------------------------------------- Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH Firmensitz: Trippstadter Straße 122, D-67663 Kaiserslautern Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster (Vorsitzender) Dr. Walter Olthoff Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes Amtsgericht Kaiserslautern, HRB 2313 Sitz der Gesellschaft: Kaiserslautern (HRB 2313) USt-Id.Nr.: DE 148646973 Steuernummer: 19/673/0060/3 ----------------------------------------------------------------------- -- Orocos-Dev mailing list [email protected] http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev