Re: [Rock-dev] [PATCH] RTT: Added way to disable exception catching

On 23.10.2013 10:29, Sylvain Joyeux wrote:
> On 10/23/2013 10:14 AM, Peter Soetens wrote:
>> Hi,
>>
>> On Tue, Oct 22, 2013 at 3:34 PM, Sylvain Joyeux<[email protected]>  wrote:
>>> @Peter: could you have a look ? There are a few things I already
>>> mentioned to Matthias (e.g. that the static variable does not work).
>> Why doesn't it, it's only used in the local compilation unit and not
>> in headers ?
> My issue with it is that it cannot then be set from within the C++ API
> (only from the runtime environment)
*fixed* -> needs a CatchConfig.cpp then also.
>>> He also needs a file into which to put the #define and all, he picked
>>> Config.hpp but I find that not so-satisfactory. Any idea there ?
>> move it into rtt/impl and make sure that no public header includes
>> it... it's subject to name clashing.
>> maybe name it rtt/impl/CatchConfig.h ?
@peter, there is currently no rtt/impl folder, should i create a new one 
for this or did you mention another one?
(what should impl stay for?)


> That sounds good.
>> Also, the patch is full of trailing whitespace... please apply the
>> final version with whitespace squelching.
*fixed*
> Agreed.
>


-- 
  Dipl.-Inf. Matthias Goldhoorn
  Space and Underwater Robotic

  Universität Bremen
  FB 3 - Mathematik und Informatik
  AG Robotik
  Robert-Hooke-Straße 5
  28359 Bremen, Germany

  Tel.:     +49 421 178 45-4193
  Zentrale: +49 421 178 45-6550
  Fax:      +49 421 178 45-4150
  E-Mail:   [email protected]

  Weitere Informationen: http://www.informatik.uni-bremen.de/robotik

-- 
Orocos-Dev mailing list
[email protected]
http://lists.mech.kuleuven.be/mailman/listinfo/orocos-dev