[ playerstage-Patches-2978343 ] memset in v4l2 driver
"SourceForge.net" <[email protected]>
| Newsgroups | gmane.science.robotics.playerstage |
|---|---|
| Message-ID | <[email protected]> |
Patches item #2978343, was opened at 2010-03-28 23:10
Message generated for change (Tracker Item Submitted) made by jashar
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=433166&aid=2978343&group_id=42445
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Player
Group: Unstable
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Jayen Ashar (jashar)
Assigned to: Brian Gerkey (gerkey)
Summary: memset in v4l2 driver
Initial Comment:
Not strictly a patch, but I noticed line 553 of playerstage > code > player > trunk > server > drivers > camera > v4l2 > camerav4l2.cc has:
memset(data, 0, sizeof data);
and i think it should be:
memset(data, 0, sizeof *data);
or, alternatively, use calloc on line 547.
--Jayen
http://playerstage.svn.sourceforge.net/viewvc/playerstage/code/player/trunk/server/drivers/camera/v4l2/camerav4l2.cc?revision=8408&view=markup
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=433166&aid=2978343&group_id=42445
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev