Somewhat incorrect multi-value query parameter processing [1 Attachment]

Nikolai Kondrashov <[email protected]> Tue, 15 Sep 2009 18:17:33 +0400
Newsgroups gmane.text.clearsilver.general
Message-ID <[email protected]>
<*>[Attachment(s) from Nikolai Kondrashov included below]

Hello everybody, Brandon

Once again, I have noticed a somewhat incorrect processing of multi-value
query parameters. Only this time I decided to fix and report it.

The problem appears when you have both node value and children in the POST,
like this:

node.child1 = a
node.child2 = b
node.child3 = c
node = d

This results in the Query dataset being like this:

node = d
node {
    child1 = a
    child2 = b
    child3 = c
    3 = d
}

This is because the _parse_query function mistakes "node" to be a
multi-value parameter, since it checks only for node presence, but not for
the value presence.

I think this is somewhat confusing, while easily fixable. Please find the
patch attached.

Sincerely,
Nick


<*>Attachment(s) from Nikolai Kondrashov:


<*> 1 of 1 File(s) http://groups.yahoo.com/group/ClearSilver/attachments/folder/664558336/item/list 
  <*> multi-value.patch

------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/ClearSilver/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/ClearSilver/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:[email protected] 
    mailto:[email protected]

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/