Does nerr_log_error free the NEO_ERR *
caox <[email protected]> Wed, 21 Dec 2011 14:28:31 +0800
| Newsgroups | gmane.text.clearsilver.general |
|---|---|
| Message-ID | <[email protected]> |
--Apple-Mail-11-396844824
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
Hi
Sorry to bother. According to the description and code example, the API n=
err_log_error should free the err chain. But I didn't find the respective c=
ode to release the err chain inside the implementation:
void nerr_log_error (NEOERR *err)
{
NEOERR *more;
char buf[1024];
char *err_name;
if (err =3D=3D STATUS_OK)
return;
if (err =3D=3D INTERNAL_ERR)
{
ne_warn ("Internal error");
return;
}
more =3D err;
fprintf (stderr, "Traceback (innermost last):\n");
while (more && more !=3D INTERNAL_ERR)
{
err =3D more;
more =3D err->next;
if (err->error !=3D NERR_PASS)
{
NEOERR *r;
if (err->error =3D=3D 0)
{
err_name =3D buf;
snprintf (buf, sizeof (buf), "Unknown Error");
}
else
{
r =3D uListGet (Errors, err->error - 1, (void *)&err_name);
if (r !=3D STATUS_OK)
{
err_name =3D buf;
snprintf (buf, sizeof (buf), "Error %d", err->error);
}
}
fprintf (stderr, " File \"%s\", line %d, in %s()\n%s: %s\n", err->fi=
le,=20
err->lineno, err->func, err_name, err->desc);
}
else
{
fprintf (stderr, " File \"%s\", line %d, in %s()\n", err->file,=20
err->lineno, err->func);
if (err->desc[0])
{
fprintf (stderr, " %s\n", err->desc);
}
}
}
}
So, is the err chain freed in other place or I have missed something inside=
the function? Does nerr_log_error free the err chain, as for nerr_err_stri=
ng and nerr_err_traceback?
Thanks.
B.R.
--Apple-Mail-11-396844824
Content-Type: text/html; charset=US-ASCII
Content-Transfer-Encoding: 7bit
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html>
<head>
</head>
<body style="background-color: #fff;">
<span style="display:none"> </span>
<!--~-|**|PrettyHtmlStartT|**|-~-->
<div id="ygrp-mlmsg" style="position:relative;">
<div id="ygrp-msg" style="z-index: 1;">
<!--~-|**|PrettyHtmlEndT|**|-~-->
<div id="ygrp-text" >
<p>Hi<div><br></div><div><span class="Apple-tab-span" style="white-space:pre;"> </span>Sorry to bother. According to the description and code example, the API nerr_log_error should free the err chain. But I didn't find the respective code to release the err chain inside the implementation:</div><div><br></div><div><div><span style="color: #a00069;">void</span> nerr_log_error (<span style="color: #006640;">NEOERR</span> *err)</div><div>{</div><div> <span style="color: #006640;">NEOERR</span> *more;</div><div> <span style="color: #a00069;">char</span> buf[1024];</div><div> <span style="color: #a00069;">char</span> *err_name;</div><div><br></div><div> <span style="color: #a00069;">if</span> (err == STATUS_OK)</div><div style="color: rgb(160, 0, 105);"><span
style="color: #000000;"> </span>return<span style="color: #000000;">;</span></div><div><br></div><div> <span style="color: #a00069;">if</span> (err == INTERNAL_ERR)</div><div> {</div><div style="color: rgb(92, 0, 255);"><span style="color: #000000;"> ne_warn (</span>"Internal error"<span style="color: #000000;">);</span></div><div style="color: rgb(160, 0, 105);"><span style="color: #000000;"> </span>return<span style="color: #000000;">;</span></div><div> }</div><div><br></div><div> more = err;</div><div style="color: rgb(92, 0, 255);"><span style="color: #000000;"> </span><span style="color: #842496;">fprintf</span><span style="color: #000000;"> (stderr, </span>"Traceback (innermost last):\n"<span style="color: #00000
0;">);</span></div><div> <span style="color: #a00069;">while</span> (more && more != INTERNAL_ERR)</div><div> {</div><div> err = more;</div><div> more = err-><span style="color: #3600d1;">next</span>;</div><div> <span style="color: #a00069;">if</span> (err-><span style="color: #3600d1;">error</span> != NERR_PASS)</div><div> {</div><div> <span style="color: #006640;">NEOERR</span> *r;</div><div> <span style="color: #a00069;">if</span> (err-><span style="color: #3600d1;">error</span> == 0)</div><div> {</div><div><span class="Apple-tab-span" style="white-space:pre;"> </span>err_name = buf;</div><div><span class="Apple-tab-span" style="white-space:pre;"
> </span>snprintf (buf, <span style="color: #a00069;">sizeof</span> (buf), <span style="color: #5c00ff;">"Unknown Error"</span>);</div><div> }</div><div> <span style="color: #a00069;">else</span></div><div> {</div><div><span class="Apple-tab-span" style="white-space:pre;"> </span>r = uListGet (Errors, err-><span style="color: #3600d1;">error</span> - 1, (<span style="color: #a00069;">void</span> *)&err_name);</div><div><span class="Apple-tab-span" style="white-space:pre;"> </span><span style="color: #a00069;">if</span> (r != STATUS_OK)</div><div><span class="Apple-tab-span" style="white-space:pre;"> </span>{</div><div><span class="Apple-tab-span" style="white-space:pre;"> </span> err_name = buf;</div><div><span clas
s="Apple-tab-span" style="white-space:pre;"> </span> snprintf (buf, <span style="color: #a00069;">sizeof</span> (buf), <span style="color: #5c00ff;">"Error %d"</span>, err-><span style="color: #3600d1;">error</span>);</div><div><span class="Apple-tab-span" style="white-space:pre;"> </span>}</div><div> }</div><div><br></div><div style="color: rgb(92, 0, 255);"><span style="color: #000000;"> </span><span style="color: #842496;">fprintf</span><span style="color: #000000;"> (stderr, </span>" File \"%s\", line %d, in %s()\n%s: %s\n"<span style="color: #000000;">, err-></span><span style="color: #3600d1;">file</span><span style="color: #000000;">, </span></div><div><span class="Apple-tab-span" style="white-space:pre;"> </span> 
; err-><span style="color: #3600d1;">lineno</span>, err-><span style="color: #3600d1;">func</span>, err_name, err-><span style="color: #3600d1;">desc</span>);</div><div> }</div><div> <span style="color: #a00069;">else</span></div><div> {</div><div style="color: rgb(92, 0, 255);"><span style="color: #000000;"> </span><span style="color: #842496;">fprintf</span><span style="color: #000000;"> (stderr, </span>" File \"%s\", line %d, in %s()\n"<span style="color: #000000;">, err-></span><span style="color: #3600d1;">file</span><span style="color: #000000;">, </span></div><div><span class="Apple-tab-span" style="white-space:pre;"> </span> err-><span style="color: #3600d1;">lineno</span>, err-><span st
yle="color: #3600d1;">func</span>);</div><div> <span style="color: #a00069;">if</span> (err-><span style="color: #3600d1;">desc</span>[0])</div><div> {</div><div><span class="Apple-tab-span" style="white-space:pre;"> </span><span style="color: #842496;">fprintf</span> (stderr, <span style="color: #5c00ff;">" %s\n"</span>, err-><span style="color: #3600d1;">desc</span>);</div><div> }</div><div> }</div><div> }</div><div>}</div></div><div><br></div><div><span class="Apple-style-span" style="font-family: 'Heiti SC';font-size: medium;">So, is the err chain freed in other place or I have missed something inside the function? Does nerr_log_error free the err chain, as for nerr_err_string and n
err_err_traceback?</span></div><div><span class="Apple-style-span" style="font-family: 'Heiti SC';font-size: medium;"><br></span></div><div><font class="Apple-style-span" face="'Heiti SC'" size="3">Thanks.</font></div><div><font class="Apple-style-span" face="'Heiti SC'" size="3"><br></font></div><div><font class="Apple-style-span" face="'Heiti SC'" size="3">B.R.</font></div></p>
</div>
<!--~-|**|PrettyHtmlStart|**|-~-->
<div style="color: #fff; height: 0;">__._,_.___</div>
<div id="ygrp-actbar" style="clear: both; margin-bottom: 10px; white-space: nowrap; color: #666; padding-top: 15px;">
<div>
<a href="mailto:[email protected]?subject=Re%3A%20Does%20nerr_log_error%20free%20the%20NEO_ERR%20%2A%20" style="margin-right: 0; padding-right: 0;">
Reply to <span style="font-weight: 700;">sender</span></a> |
<a href="mailto:[email protected]?subject=Re%3A%20Does%20nerr_log_error%20free%20the%20NEO_ERR%20%2A%20">
Reply to <span style="font-weight: 700;">group</span></a> |
<a href="http://groups.yahoo.com/group/ClearSilver/post;_ylc=X3oDMTJwcWpwZzBpBF9TAzk3MzU5NzE0BGdycElkAzM1NjQxMzcEZ3Jwc3BJZAMxNzA3MjgxOTQyBG1zZ0lkAzE0MjQEc2VjA2Z0cgRzbGsDcnBseQRzdGltZQMxMzI0NDQ4OTIz?act=reply&messageNum=1424">Reply <span style="font-weight: 700;">via web post</span></a> |
<a href="http://groups.yahoo.com/group/ClearSilver/post;_ylc=X3oDMTJlcXFwM3E2BF9TAzk3MzU5NzE0BGdycElkAzM1NjQxMzcEZ3Jwc3BJZAMxNzA3MjgxOTQyBHNlYwNmdHIEc2xrA250cGMEc3RpbWUDMTMyNDQ0ODkyMw--" style="font-weight: 700;">Start a New Topic</a>
</div>
<a href="http://groups.yahoo.com/group/ClearSilver/message/1424;_ylc=X3oDMTM0azAycHYyBF9TAzk3MzU5NzE0BGdycElkAzM1NjQxMzcEZ3Jwc3BJZAMxNzA3MjgxOTQyBG1zZ0lkAzE0MjQEc2VjA2Z0cgRzbGsDdnRwYwRzdGltZQMxMzI0NDQ4OTIzBHRwY0lkAzE0MjQ-">Messages in this topic</a>
(<span style="font-weight: 700;">1</span>)
</div>
<!------- Start Nav Bar ------>
<!-- |**|begin egp html banner|**| -->
<div id="ygrp-vital" style="background-color: #e0ecee; font-family: Verdana; font-size: 10px; margin-bottom: 10px; padding: 10px;">
<span id="vithd" style="font-weight: bold; color: #333; text-transform: uppercase; ">Recent Activity:</span>
<ul style="list-style-type: none; margin: 0; padding: 0; display: inline;">
</ul>
<div style="clear: both; padding-top: 2px; color: #1e66ae;">
<a href="http://groups.yahoo.com/group/ClearSilver;_ylc=X3oDMTJldjByb21sBF9TAzk3MzU5NzE0BGdycElkAzM1NjQxMzcEZ3Jwc3BJZAMxNzA3MjgxOTQyBHNlYwN2dGwEc2xrA3ZnaHAEc3RpbWUDMTMyNDQ0ODkyMw--" style="text-decoration: none;">Visit Your Group</a>
</div>
</div>
<div id="ygrp-mkp" style="border: 1px solid #d8d8d8; clear: both; float: left; font-family: Arial; margin: 5px 0 10px 0; padding: 0 10px;">
<div id="hd" style="color: #628c2a; font-size: 85%; font-weight: 700; line-height: 122%; margin: 10px 0;">MARKETPLACE</div>
<div id="ads" style="margin-bottom: 10px;">
<div class="ad" style="color: #628C2A; font-family: Arial; font-weight: 700; padding: 0 0;">
<p><a href="http://global.ard.yahoo.com/SIG=15os0dt6k/M=493064.14543979.14562481.13298430/D=groups/S=1707281942:MKP1/Y=YAHOO/EXP=1324456123/L=07c91672-2b9d-11e1-9e29-0bb5a0462b0c/B=ZY4qANGDJHk-/J=1324448923877626/K=_XLtDnZ97lpm9ewkpMtBnQ/A=6060255/R=0/SIG=1194m4keh/*http://us.toolbar.yahoo.com/?.cpdl=grpj">Stay on top of your group activity without leaving the page you're on - Get the Yahoo! Toolbar now.</a></p> <script language=javascript>
if(window.yzq_d==null)window.yzq_d=new Object();
window.yzq_d['ZY4qANGDJHk-']='&U=13c5gmu2j%2fN%3dZY4qANGDJHk-%2fC%3d493064.14543979.14562481.13298430%2fD%3dMKP1%2fB%3d6060255%2fV%3d1';
</script><noscript><img width=1 height=1 alt="" src="http://us.bc.yahoo.com/b?P=07c91672-2b9d-11e1-9e29-0bb5a0462b0c&T=1d5nli98l%2fX%3d1324448923%2fE%3d1707281942%2fR%3dgroups%2fK%3d5%2fV%3d2.1%2fW%3dH%2fY%3dYAHOO%2fF%3d1603570571%2fH%3dY29udGVudD0iR287UG9kY2FzdHM7V2lkZ2V0cztGbGlja3I7WWFob29fU2VhcmNoX01hcmtldGluZztGaW5hbmNlO0Jvb2ttYXJrO01lc3NhZ2VfQm9hcmRzO0NhbGVuZGFyO0V2ZW50czsiIGRpc2FibGVzaHVmZmxpbmc9IjEiIHNlcnZlSWQ9IjA3YzkxNjcyLTJiOWQtMTFlMS05ZTI5LTBiYjVhMDQ2MmIwYyIgc2l0ZUlkPSI0NDUyNTUxIiB0U3RtcD0iMTMyNDQ0ODkyMzgzMDgxNCIg%2fQ%3d-1%2fS%3d1%2fJ%3d26228962&U=13c5gmu2j%2fN%3dZY4qANGDJHk-%2fC%3d493064.14543979.14562481.13298430%2fD%3dMKP1%2fB%3d6060255%2fV%3d1"></noscript><!--QYZ ,;;MKP1;1707281942;2;--> </div>
</div>
</div>
<div id="ft" style="font-family: Arial; font-size: 11px; margin-top: 5px; padding: 0 2px 0 0; clear: both;">
<a href="http://groups.yahoo.com/;_ylc=X3oDMTJkZm1kOWM5BF9TAzk3NDc2NTkwBGdycElkAzM1NjQxMzcEZ3Jwc3BJZAMxNzA3MjgxOTQyBHNlYwNmdHIEc2xrA2dmcARzdGltZQMxMzI0NDQ4OTIz" style="float: left;"><img src="http://l.yimg.com/a/i/us/yg/logo/us.gif" height="15" width="137" alt="Yahoo! Groups" style="border: 0;"/></a>
<div style="color: #747575; float: right;">Switch to: <a href="mailto:[email protected]?subject=Change Delivery Format: Traditional" style="text-decoration: none;">Text-Only</a>, <a href="mailto:[email protected]?subject=Email Delivery: Digest" class="margin-rt" style="text-decoration: none;">Daily Digest</a> • <a href="mailto:[email protected]?subject=Unsubscribe" style="text-decoration: none;">Unsubscribe</a> • <a href="http://docs.yahoo.com/info/terms/" style="text-decoration: none;">Terms of Use</a></div>
</div>
<!-- |**|end egp html banner|**| -->
</div> <!-- ygrp-msg -->
<!-- Sponsor -->
<!-- |**|begin egp html banner|**| -->
<div id="ygrp-sponsor" style="width:160px; float:right; clear:none; margin:0 0 25px 0; background: #fff;">
<!-- Start Recommendations -->
<div id="ygrp-reco">
</div>
<!-- End Recommendations -->
</div> <!-- |**|end egp html banner|**| -->
<div style="clear:both; color: #FFF; font-size:1px;">.</div>
</div>
<img src="http://geo.yahoo.com/serv?s=97359714/grpId=3564137/grpspId=1707281942/msgId=1424/stime=1324448923/nc1=4507179/nc2=3848640/nc3=5741395" width="1" height="1"> <br>
<div style="color: #fff; height: 0;">__,_._,___</div>
<!--~-|**|PrettyHtmlEnd|**|-~-->
</body>
<!--~-|**|PrettyHtmlStart|**|-~-->
<head>
<style type="text/css">
<!--
#ygrp-mkp {
border: 1px solid #d8d8d8;
font-family: Arial;
margin: 10px 0;
padding: 0 10px;
}
#ygrp-mkp hr {
border: 1px solid #d8d8d8;
}
#ygrp-mkp #hd {
color: #628c2a;
font-size: 85%;
font-weight: 700;
line-height: 122%;
margin: 10px 0;
}
#ygrp-mkp #ads {
margin-bottom: 10px;
}
#ygrp-mkp .ad {
padding: 0 0;
}
#ygrp-mkp .ad p {
margin: 0;
}
#ygrp-mkp .ad a {
color: #0000ff;
text-decoration: none;
}
#ygrp-sponsor #ygrp-lc {
font-family: Arial;
}
#ygrp-sponsor #ygrp-lc #hd {
margin: 10px 0px;
font-weight: 700;
font-size: 78%;
line-height: 122%;
}
#ygrp-sponsor #ygrp-lc .ad {
margin-bottom: 10px;
padding: 0 0;
}
a {
color: #1e66ae;
}
#actions {
font-family: Verdana;
font-size: 11px;
padding: 10px 0;
}
#activity {
background-color: #e0ecee;
float: left;
font-family: Verdana;
font-size: 10px;
padding: 10px;
}
#activity span {
font-weight: 700;
}
#activity span:first-child {
text-transform: uppercase;
}
#activity span a {
color: #5085b6;
text-decoration: none;
}
#activity span span {
color: #ff7900;
}
#activity span .underline {
text-decoration: underline;
}
.attach {
clear: both;
display: table;
font-family: Arial;
font-size: 12px;
padding: 10px 0;
width: 400px;
}
.attach div a {
text-decoration: none;
}
.attach img {
border: none;
padding-right: 5px;
}
.attach label {
display: block;
margin-bottom: 5px;
}
.attach label a {
text-decoration: none;
}
blockquote {
margin: 0 0 0 4px;
}
.bold {
font-family: Arial;
font-size: 13px;
font-weight: 700;
}
.bold a {
text-decoration: none;
}
dd.last p a {
font-family: Verdana;
font-weight: 700;
}
dd.last p span {
margin-right: 10px;
font-family: Verdana;
font-weight: 700;
}
dd.last p span.yshortcuts {
margin-right: 0;
}
div.attach-table div div a {
text-decoration: none;
}
div.attach-table {
width: 400px;
}
div.file-title a, div.file-title a:active, div.file-title a:hover, div.file-title a:visited {
text-decoration: none;
}
div.photo-title a, div.photo-title a:active, div.photo-title a:hover, div.photo-title a:visited {
text-decoration: none;
}
div#ygrp-mlmsg #ygrp-msg p a span.yshortcuts {
font-family: Verdana;
font-size: 10px;
font-weight: normal;
}
.green {
color: #628c2a;
}
.MsoNormal {
margin: 0 0 0 0;
}
o {
font-size: 0;
}
#photos div {
float: left;
width: 72px;
}
#photos div div {
border: 1px solid #666666;
height: 62px;
overflow: hidden;
width: 62px;
}
#photos div label {
color: #666666;
font-size: 10px;
overflow: hidden;
text-align: center;
white-space: nowrap;
width: 64px;
}
#reco-category {
font-size: 77%;
}
#reco-desc {
font-size: 77%;
}
.replbq {
margin: 4px;
}
#ygrp-actbar div a:first-child {
/* border-right: 0px solid #000;*/
margin-right: 2px;
padding-right: 5px;
}
#ygrp-mlmsg {
font-size: 13px;
font-family: Arial, helvetica,clean, sans-serif;
*font-size: small;
*font: x-small;
}
#ygrp-mlmsg table {
font-size: inherit;
font: 100%;
}
#ygrp-mlmsg select, input, textarea {
font: 99% Arial, Helvetica, clean, sans-serif;
}
#ygrp-mlmsg pre, code {
font:115% monospace;
*font-size:100%;
}
#ygrp-mlmsg * {
line-height: 1.22em;
}
#ygrp-mlmsg #logo {
padding-bottom: 10px;
}
#ygrp-mlmsg a {
color: #1E66AE;
}
#ygrp-msg p a {
font-family: Verdana;
}
#ygrp-msg p#attach-count span {
color: #1E66AE;
font-weight: 700;
}
#ygrp-reco #reco-head {
color: #ff7900;
font-weight: 700;
}
#ygrp-reco {
margin-bottom: 20px;
padding: 0px;
}
#ygrp-sponsor #ov li a {
font-size: 130%;
text-decoration: none;
}
#ygrp-sponsor #ov li {
font-size: 77%;
list-style-type: square;
padding: 6px 0;
}
#ygrp-sponsor #ov ul {
margin: 0;
padding: 0 0 0 8px;
}
#ygrp-text {
font-family: Georgia;
}
#ygrp-text p {
margin: 0 0 1em 0;
}
#ygrp-text tt {
font-size: 120%;
}
#ygrp-vital ul li:last-child {
border-right: none !important;
}
-->
</style>
</head>
<!--~-|**|PrettyHtmlEnd|**|-~-->
</html>
<!-- end group email -->
--Apple-Mail-11-396844824--