Re: Does nerr_log_error free the NEO_ERR *
Brandon Long <[email protected]> Wed, 21 Dec 2011 11:18:07 -0800
| Newsgroups | gmane.text.clearsilver.general |
|---|---|
| Message-ID | <CAA6MhGuZa_egCd6DKPC_LJMcCoL-eQ39ki1su2b4T7tGiZ5Vnw@mail.gmail.com> |
--0015175cfd7e38e8fd04b49f0bd0 Content-Type: text/plain; charset=ISO-8859-1 I don't think any of those free the error chain, where did you get that impression? Its not in the api docs, as near as I can tell. Brandon On Tue, Dec 20, 2011 at 10:28 PM, caox <[email protected]> wrote: > > > Hi > > Sorry to bother. According to the description and code example, the API > nerr_log_error should free the err chain. But I didn't find the respective > code to release the err chain inside the implementation: > > void nerr_log_error (NEOERR *err) > { > NEOERR *more; > char buf[1024]; > char *err_name; > > if (err == STATUS_OK) > return; > > if (err == INTERNAL_ERR) > { > ne_warn ("Internal error"); > return; > } > > more = err; > fprintf (stderr, "Traceback (innermost last):\n"); > while (more && more != INTERNAL_ERR) > { > err = more; > more = err->next; > if (err->error != NERR_PASS) > { > NEOERR *r; > if (err->error == 0) > { > err_name = buf; > snprintf (buf, sizeof (buf), "Unknown Error"); > } > else > { > r = uListGet (Errors, err->error - 1, (void *)&err_name); > if (r != STATUS_OK) > { > err_name = buf; > snpri ntf (buf, sizeof (buf), "Error %d", err->error); > } > } > > fprintf (stder r, " File \"%s\", line %d, in %s()\n%s: %s\n", err-> > file, > err->lineno, err->func, err_name, err->desc); > } > else > { > fprintf (stderr, " File \"%s\", line %d, in %s()\n", err->file, > err->lineno, err->func); > if (err->desc[0]) > { > fprintf (stderr, " %s\n", err->desc); > } > } > } > } > > So, is the err chain freed in other place or I have missed something > inside the function? Does nerr_log_error free the err chain, as for > nerr_err_string and nerr_err_traceback? > > Thanks. > > B.R. > > > --0015175cfd7e38e8fd04b49f0bd0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/htm= l4/strict.dtd"> <html> <head> </head> <body style=3D"background-color: #fff;"> <span style=3D"display:none"> </span> <!--~-|**|PrettyHtmlStartT|**|-~--> <div id=3D"ygrp-mlmsg" style=3D"position:relative;"> <div id=3D"ygrp-msg" style=3D"z-index: 1;"> <!--~-|**|PrettyHtmlEndT|**|-~--> <div id=3D"ygrp-text" > =20=20=20=20=20=20 =20=20=20=20=20=20 <p>I don't think any of those free the error chain, where did you= get that impression? =A0Its not in the api docs, as near as I can tell.<di= v><br></div><div>Brandon<br><br><div class=3D"gmail_quote">On Tue, Dec 20, = 2011 at 10:28 PM, caox <span dir=3D"ltr"><<a href=3D"mailto:caox@lightpo= le.net">[email protected]</a>></span> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"border-left:1px #ccc solid;"> =20=20=20=20=20=20=20=20 <div> <br><br> Hi<div><br></div><div><span style=3D"white-space:pre-wrap;"> </span>Sorry t= o bother. According to the description and code example, the API =A0nerr_lo= g_error should free the err chain. But I didn't find the respective cod= e to release the err chain inside the implementation:</div> <div><br></div><div><div><span style=3D"color:#a00069;">void</span> nerr_lo= g_error (<span style=3D"color:#006640;">NEOERR</span> *err)</div> <div>{</div><div> =A0 <span style=3D"color:#006640;">NEOERR</span> *more;</div><div>=A0 <span= style=3D"color:#a00069;">char</span> buf[1024];</div><div> =A0 <span style=3D"color:#a00069;">char</span> *err_name;</div><div><br></d= iv><div> =A0 <span style=3D"color:#a00069;">if</span> (err =3D=3D STATUS_OK)</div><d= iv style=3D"color:rgb(160,0,105);"><span style=3D"color:#000000;">=A0 =A0 <= /span>return<span style=3D"color:#000000;">;</span></div> <div><br></div><div>=A0 <span style=3D"color:#a00069;">if</span> (err =3D= =3D INTERNAL_ERR)</div><div> =A0 {</div><div style=3D"color:rgb(92,0,255);"><span style=3D"color:#000000= ;">=A0 =A0 ne_warn (</span>"Internal error"<span style=3D"color:#= 000000;">);</span></div> <div style=3D"color:rgb(160,0,105);"><span style=3D"color:#000000;">=A0 =A0= </span>return<span>;</span></div><div> =A0 }</div><div><br></div><div> =A0 more =3D err;</div><div style=3D"color:rgb(92,0,255);"><span style=3D"c= olor:#000000;">=A0 </span><span style=3D"color:#842496;">fprintf</span><spa= n style=3D"color:#000000;"> (stderr, </span>"Traceback (innermost last= ):\n"<span style=3D"color:#000000;">);</span></div> <div> =A0 <span style=3D"color:#a00069;">while</span> (more && more !=3D= INTERNAL_ERR)</div><div>=A0 {</div> <div>=A0 =A0 err =3D more;</div><div> =A0 =A0 more =3D err-><span style=3D"color:#3600d1;">next</span>;</div><= div>=A0 =A0 <span style=3D"color:#a00069;">if</span> (err-><span style= =3D"color:#3600d1;">error</span> !=3D NERR_PASS)</div> <div>=A0 =A0 {</div><div> =A0 =A0 =A0 <span style=3D"color:#006640;">NEOERR</span> *r;</div><div>=A0 = =A0 =A0 <span style=3D"color:#a00069;">if</span> (err-><span style=3D"co= lor:#3600d1;">error</span> =3D=3D 0)</div> <div>=A0 =A0 =A0 {</div><div> <span style=3D"white-space:pre-wrap;"> </span>err_name =3D buf;</div><div><= span style=3D"white-space:pre-wrap;"> </span>snprintf (buf, <span style=3D"= color:#a00069;">sizeof</span> (buf), <span style=3D"color:#5c00ff;">"U= nknown Error"</span>);</div> <div>=A0 =A0 =A0 }</div><div> =A0 =A0 =A0 <span style=3D"color:#a00069;">else</span></div><div>=A0 =A0 = =A0 {</div><div> <span style=3D"white-space:pre-wrap;"> </span>r =3D uListGet (Errors, err-&= gt;<span>error</span> - 1, (<span style=3D"color:#a00069;">void</span> *)&a= mp;err_name);</div><div> <span style=3D"white-space:pre-wrap;"> </span><span style=3D"color:#a00069;= ">if</span> (r !=3D STATUS_OK)</div><div> <span style=3D"white-space:pre-wrap;"> </span>{</div><div><span style=3D"wh= ite-space:pre-wrap;"> </span>=A0 err_name =3D buf;</div> <div><span style=3D"white-space:pre-wrap;"> </span>=A0 snpri ntf (buf, <span style=3D"color:#a00069;">sizeof</span> (buf), <span style= =3D"color:#5c00ff;">"Error %d"</span>, err-><span style=3D"col= or:#3600d1;">error</span>);</div><div> <span style=3D"white-space:pre-wrap;"> </span>}</div><div>=A0 =A0 =A0 }</di= v><div> <br></div><div style=3D"color:rgb(92,0,255);"><span style=3D"color:#000000;= ">=A0 =A0 =A0 </span><span style=3D"color:#842496;">fprintf</span><span sty= le=3D"color:#000000;"> (stder r, </span>"=A0 File \"%s\", line %d, in %s()\n%s: %s\n"= ;<span style=3D"color:#000000;">, err-></span><span style=3D"color:#3600= d1;">file</span><span style=3D"color:#000000;">,=A0</span></div><div> <span style=3D"white-space:pre-wrap;"> </span>=A0 err-><span style=3D"co= lor:#3600d1;">lineno</span>, err-><span style=3D"color:#3600d1;">func</s= pan>, err_name, err-><span style=3D"color:#3600d1;">desc</span>);</div><= div> =A0 =A0 }</div><div>=A0 =A0 <span style=3D"color:#a00069;">else</span></div= ><div>=A0 =A0 {</div><div style=3D"color:rgb(92,0,255);"> <span style=3D"color:#000000;">=A0 =A0 =A0 </span><span style=3D"color:#842= 496;">fprintf</span><span style=3D"color:#000000;"> (stderr, </span>"= =A0 File \"%s\", line %d, in %s()\n"<span style=3D"color:#00= 0000;">, err-></span><span style=3D"color:#3600d1;">file</span><span sty= le=3D"color:#000000;">,=A0</span></div> <div><span style=3D"white-space:pre-wrap;"> </span>=A0 err-><span style= =3D"color:#3600d1;">lineno</span>, err-><span style=3D"color:#3600d1;">f= unc</span>);</div> <div>=A0 =A0 =A0 <span style=3D"color:#a00069;">if</span> (err-><span st= yle=3D"color:#3600d1;">desc</span>[0])</div> <div>=A0 =A0 =A0 {</div><div> <span style=3D"white-space:pre-wrap;"> </span><span style=3D"color:#842496;= ">fprintf</span> (stderr, <span style=3D"color:#5c00ff;">"=A0 =A0 %s\n= "</span>, err-><span style=3D"color:#3600d1;">desc</span>);</div><d= iv> =A0 =A0 =A0 }</div><div>=A0 =A0 }</div><div>=A0 }</div><div> }</div></div><div><br></div><div> <span style=3D"font-family:'Heiti SC';font-size:medium;">So, is the err cha= in freed in other place or I have missed something inside the function? Doe= s=A0nerr_log_error free the err chain, as for nerr_err_string and nerr_err_= traceback?</span></div> <div><span style=3D"font-family:'Heiti SC';font-size:medium;"><br></span></= div><div> <font face=3D"'Heiti SC'" size=3D"3">Thanks.</font></div><div><font= face=3D"'Heiti SC'" size=3D"3"><br> </font></div><div><font face=3D"'Heiti SC'" size=3D"3">B.R.</font><= /div> <br> =20=20=20=20 =20=20=20=20 <br> <div width=3D"1" style=3D"color:white;"></div> </div></blockquote></div><br></div> </p> </div> =20=20=20=20=20 <!--~-|**|PrettyHtmlStart|**|-~--> <div style=3D"color: #fff; height: 0;">__._,_.___</div> =20=20=20=20=20=20=20=20 =20=20 =20=20=20 <div id=3D"ygrp-actbar" style=3D"clear: both; margin-bottom: 10px; whit= e-space: nowrap; color: #666; padding-top: 15px;"> <div> <a href=3D"mailto:[email protected]?subject=3DRe%3A%20Does%20nerr_l= og_error%20free%20the%20NEO_ERR%20%2A" style=3D"margin-right: 0; padding-ri= ght: 0;"> Reply to <span style=3D"font-weight: 700;">sender</span></a> | <a href=3D"mailto:[email protected]?subject=3DRe%3A%20Doe= s%20nerr_log_error%20free%20the%20NEO_ERR%20%2A"> Reply to <span style=3D"font-weight: 700;">group</span></a> | <a href=3D"http://groups.yahoo.com/group/ClearSilver/post;_ylc= =3DX3oDMTJwaTFjMXNvBF9TAzk3MzU5NzE0BGdycElkAzM1NjQxMzcEZ3Jwc3BJZAMxNzA3Mjgx= OTQyBG1zZ0lkAzE0MjUEc2VjA2Z0cgRzbGsDcnBseQRzdGltZQMxMzI0NDk1MDkx?act=3Drepl= y&messageNum=3D1425">Reply <span style=3D"font-weight: 700;">via web post</= span></a> | <a href=3D"http://groups.yahoo.com/group/ClearSilver/post;_ylc= =3DX3oDMTJlaTZxNXNoBF9TAzk3MzU5NzE0BGdycElkAzM1NjQxMzcEZ3Jwc3BJZAMxNzA3Mjgx= OTQyBHNlYwNmdHIEc2xrA250cGMEc3RpbWUDMTMyNDQ5NTA5MQ--" style=3D"font-weight:= 700;">Start a New Topic</a> </div> <a href=3D"http://groups.yahoo.com/group/ClearSilver/messag= e/1424;_ylc=3DX3oDMTM0OTBhZDYxBF9TAzk3MzU5NzE0BGdycElkAzM1NjQxMzcEZ3Jwc3BJZ= AMxNzA3MjgxOTQyBG1zZ0lkAzE0MjUEc2VjA2Z0cgRzbGsDdnRwYwRzdGltZQMxMzI0NDk1MDkx= BHRwY0lkAzE0MjQ-">Messages in this topic</a> (<span style=3D"font-weight: 700;">2</span>) </div>=20 <!------- Start Nav Bar ------> <!-- |**|begin egp html banner|**| --> <div id=3D"ygrp-vital" style=3D"background-color: #e0ecee; font-family: Ver= dana; font-size: 10px; margin-bottom: 10px; padding: 10px;"> <span id=3D"vithd" style=3D"font-weight: bold; color: #333; text-tran= sform: uppercase; ">Recent Activity:</span> <ul style=3D"list-style-type: none; margin: 0; padding: 0; display: inl= ine;"> </ul> =20=20=20=20 <div style=3D"clear: both; padding-top: 2px; color: #1e66ae;"> <a href=3D"http://groups.yahoo.com/group/ClearSilver;_ylc=3DX3oDMTJlMzJ= 1cmVqBF9TAzk3MzU5NzE0BGdycElkAzM1NjQxMzcEZ3Jwc3BJZAMxNzA3MjgxOTQyBHNlYwN2dG= wEc2xrA3ZnaHAEc3RpbWUDMTMyNDQ5NTA5MQ--" style=3D"text-decoration: none;">Vi= sit Your Group</a> </div> </div> <div id=3D"ygrp-mkp" style=3D"border: 1px solid #d8d8d8; clea= r: both; float: left; font-family: Arial; margin: 5px 0 10px 0; padding: 0 = 10px;"> <div id=3D"hd" style=3D"color: #628c2a; font-size: 85%; font-weight: = 700; line-height: 122%; margin: 10px 0;">MARKETPLACE</div> <div id=3D"ads" style=3D"margin-bottom: 10px;"> <div class=3D"ad" style=3D"color: #628C2A; font-family: A= rial; font-weight: 700; padding: 0 0;"> <p><a href=3D"http://global.ard.yahoo.com/SIG=3D15oaan0o9/M=3D4= 93064.14543979.14562481.13298430/D=3Dgroups/S=3D1707281942:MKP1/Y=3DYAHOO/E= XP=3D1324502291/L=3D85a47f6c-2c08-11e1-a3f8-eb2e30ff35d6/B=3DzXUdR0PDhFE-/J= =3D1324495091204529/K=3DjMzBL2oiGAj2QnHG1NIq7w/A=3D6060255/R=3D0/SIG=3D1194= m4keh/*http://us.toolbar.yahoo.com/?.cpdl=3Dgrpj">Stay on top of your group= activity without leaving the page you're on - Get the Yahoo! Toolbar now.<= /a></p> <script language=3Djavascript> if(window.yzq_d=3D=3Dnull)window.yzq_d=3Dnew Object(); window.yzq_d['zXUdR0PDhFE-']=3D'&U=3D13cj0dhqf%2fN%3dzXUdR0PDhFE-%2fC%3d493= 064.14543979.14562481.13298430%2fD%3dMKP1%2fB%3d6060255%2fV%3d1'; </script><noscript><img width=3D1 height=3D1 alt=3D"" src=3D"http://us.bc.y= ahoo.com/b?P=3D85a47f6c-2c08-11e1-a3f8-eb2e30ff35d6&T=3D1d4266mnv%2fX%3d132= 4495091%2fE%3d1707281942%2fR%3dgroups%2fK%3d5%2fV%3d2.1%2fW%3dH%2fY%3dYAHOO= %2fF%3d392066949%2fH%3dY29udGVudD0iR287UG9kY2FzdHM7V2lkZ2V0cztGbGlja3I7WWFo= b29fU2VhcmNoX01hcmtldGluZztGaW5hbmNlO0Jvb2ttYXJrO01lc3NhZ2VfQm9hcmRzO0NhbGV= uZGFyO0V2ZW50czsiIGRpc2FibGVzaHVmZmxpbmc9IjEiIHNlcnZlSWQ9Ijg1YTQ3ZjZjLTJjMD= gtMTFlMS1hM2Y4LWViMmUzMGZmMzVkNiIgc2l0ZUlkPSI0NDUyNTUxIiB0U3RtcD0iMTMyNDQ5N= TA5MTEzNDA0NyIg%2fQ%3d-1%2fS%3d1%2fJ%3d25228962&U=3D13cj0dhqf%2fN%3dzXUdR0P= DhFE-%2fC%3d493064.14543979.14562481.13298430%2fD%3dMKP1%2fB%3d6060255%2fV%= 3d1"></noscript><!--QYZ ,;;MKP1;1707281942;2;--> </div> </div> </div> =20=20 <div id=3D"ft" style=3D"font-family: Arial; font-size: 11px; margin-top: 5p= x; padding: 0 2px 0 0; clear: both;"> <a href=3D"http://groups.yahoo.com/;_ylc=3DX3oDMTJkNmdjczdpBF9TAzk3NDc2NT= kwBGdycElkAzM1NjQxMzcEZ3Jwc3BJZAMxNzA3MjgxOTQyBHNlYwNmdHIEc2xrA2dmcARzdGltZ= QMxMzI0NDk1MDkx" style=3D"float: left;"><img src=3D"http://l.yimg.com/a/i/u= s/yg/logo/us.gif" height=3D"15" width=3D"137" alt=3D"Yahoo! Groups" style= =3D"border: 0;"/></a> <div style=3D"color: #747575; float: right;">Switch to: <a href=3D"mailto= :[email protected]?subject=3DChange Delivery Format: = Traditional" style=3D"text-decoration: none;">Text-Only</a>, <a href=3D"mai= lto:[email protected]?subject=3DEmail Delivery: Digest" cl= ass=3D"margin-rt" style=3D"text-decoration: none;">Daily Digest</a> • = <a href=3D"mailto:[email protected]?subject=3DUnsubsc= ribe" style=3D"text-decoration: none;">Unsubscribe</a> • <a href=3D"ht= tp://docs.yahoo.com/info/terms/" style=3D"text-decoration: none;">Terms of = Use</a></div> </div> <!-- |**|end egp html banner|**| --> </div> <!-- ygrp-msg --> <!-- Sponsor --> <!-- |**|begin egp html banner|**| --> <div id=3D"ygrp-sponsor" style=3D"width:160px; float:right; clear:none; m= argin:0 0 25px 0; background: #fff;"> <!-- Start Recommendations --> <div id=3D"ygrp-reco"> </div> <!-- End Recommendations --> </div> <!-- |**|end egp html banner|**| --> <div style=3D"clear:both; color: #FFF; font-size:1px;">.</div> </div> <img src=3D"http://geo.yahoo.com/serv?s=3D97359714/grpId=3D3564137/grpspI= d=3D1707281942/msgId=3D1425/stime=3D1324495091/nc1=3D3848642/nc2=3D5191953/= nc3=3D4507179" width=3D"1" height=3D"1"> <br> <div style=3D"color: #fff; height: 0;">__,_._,___</div> <!--~-|**|PrettyHtmlEnd|**|-~--> </body> <!--~-|**|PrettyHtmlStart|**|-~--> <head> <style type=3D"text/css"> <!-- #ygrp-mkp { border: 1px solid #d8d8d8; font-family: Arial; margin: 10px 0; padding: 0 10px; } #ygrp-mkp hr { border: 1px solid #d8d8d8; } #ygrp-mkp #hd { color: #628c2a; font-size: 85%; font-weight: 700; line-height: 122%; margin: 10px 0; } #ygrp-mkp #ads { margin-bottom: 10px; } #ygrp-mkp .ad { padding: 0 0; } #ygrp-mkp .ad p { margin: 0; } #ygrp-mkp .ad a { color: #0000ff; text-decoration: none; } #ygrp-sponsor #ygrp-lc { font-family: Arial; } #ygrp-sponsor #ygrp-lc #hd { margin: 10px 0px; font-weight: 700; font-size: 78%; line-height: 122%; } #ygrp-sponsor #ygrp-lc .ad { margin-bottom: 10px; padding: 0 0; } a { color: #1e66ae; } #actions { font-family: Verdana; font-size: 11px; padding: 10px 0; } #activity { background-color: #e0ecee; float: left; font-family: Verdana; font-size: 10px; padding: 10px; } #activity span { font-weight: 700; } #activity span:first-child { text-transform: uppercase; } #activity span a { color: #5085b6; text-decoration: none; } #activity span span { color: #ff7900; } #activity span .underline { text-decoration: underline; } .attach { clear: both; display: table; font-family: Arial; font-size: 12px; padding: 10px 0; width: 400px; } .attach div a { text-decoration: none; } .attach img { border: none; padding-right: 5px; } .attach label { display: block; margin-bottom: 5px; } .attach label a { text-decoration: none; } =20=20 blockquote { margin: 0 0 0 4px; } .bold { font-family: Arial; font-size: 13px; font-weight: 700; } .bold a { text-decoration: none; } dd.last p a { font-family: Verdana; font-weight: 700; } dd.last p span { margin-right: 10px; font-family: Verdana; font-weight: 700; } dd.last p span.yshortcuts { margin-right: 0; } div.attach-table div div a { text-decoration: none; } div.attach-table { width: 400px; } div.file-title a, div.file-title a:active, div.file-title a:hover, div.fi= le-title a:visited { text-decoration: none; } div.photo-title a, div.photo-title a:active, div.photo-title a:hover, div= .photo-title a:visited { text-decoration: none; } div#ygrp-mlmsg #ygrp-msg p a span.yshortcuts { font-family: Verdana; font-size: 10px; font-weight: normal; } .green { color: #628c2a; } .MsoNormal { margin: 0 0 0 0; } o { font-size: 0; } #photos div { float: left; width: 72px; } #photos div div { border: 1px solid #666666; height: 62px; overflow: hidden; width: 62px; } #photos div label { color: #666666; font-size: 10px; overflow: hidden; text-align: center; white-space: nowrap; width: 64px; } #reco-category { font-size: 77%; } #reco-desc { font-size: 77%; } .replbq { margin: 4px; } #ygrp-actbar div a:first-child { /* border-right: 0px solid #000;*/ margin-right: 2px; padding-right: 5px; } #ygrp-mlmsg { font-size: 13px; font-family: Arial, helvetica,clean, sans-serif; *font-size: small; *font: x-small; } #ygrp-mlmsg table { font-size: inherit; font: 100%; } #ygrp-mlmsg select, input, textarea { font: 99% Arial, Helvetica, clean, sans-serif; } #ygrp-mlmsg pre, code { font:115% monospace; *font-size:100%; } #ygrp-mlmsg * { line-height: 1.22em; } #ygrp-mlmsg #logo { padding-bottom: 10px; } #ygrp-mlmsg a { color: #1E66AE; } #ygrp-msg p a { font-family: Verdana; } #ygrp-msg p#attach-count span { color: #1E66AE; font-weight: 700; } #ygrp-reco #reco-head { color: #ff7900; font-weight: 700; } #ygrp-reco { margin-bottom: 20px; padding: 0px; } #ygrp-sponsor #ov li a { font-size: 130%; text-decoration: none; } #ygrp-sponsor #ov li { font-size: 77%; list-style-type: square; padding: 6px 0; }=20 #ygrp-sponsor #ov ul { margin: 0; padding: 0 0 0 8px; } #ygrp-text { font-family: Georgia; } #ygrp-text p { margin: 0 0 1em 0; } #ygrp-text tt { font-size: 120%; } #ygrp-vital ul li:last-child { border-right: none !important;=20 }=20 --> </style> </head> <!--~-|**|PrettyHtmlEnd|**|-~--> </html> <!-- end group email --> --0015175cfd7e38e8fd04b49f0bd0--