Re: Build error for Ninja Generator

masaru tsuchiyama <[email protected]> Wed, 02 May 2018 22:50:01 +0000
Newsgroups gmane.text.doxygen.devel
Message-ID <CAKQP9efimjkV3Q9X=nbuvK-Gb=f2iYNyXM5aDqpsKs--B4zeDA@mail.gmail.com>
--===============7713732943162571122==
Content-Type: multipart/alternative; boundary="000000000000d3fec6056b40e890"

--000000000000d3fec6056b40e890
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

I commented to the pull request.


2018=E5=B9=B45=E6=9C=883=E6=97=A5(=E6=9C=A8) 1:32 Albert <albert.tests@gmai=
l.com>:

> I've just pushed a proposed patch to github (pull request 712,
> https://github.com/doxygen/doxygen/pull/712).
>
> Albert
>
> On Wed, May 2, 2018 at 4:03 PM, Albert <[email protected]> wrote:
>
>> Dear Masaru,
>>
>> A bit strange. The construct as used for TEST_FLAGS is the same construc=
t
>> as used for e.g. LEX_FLAGS ad BISON_FLAGS
>> Do you have an idea why it is working for LEX_FLAGS / YACC_FLAGS and not
>> for TEST_FLAGS.
>>
>> I tried to create a Ninja version under Windows but I fail due to the
>> fact that cmake cannot find bison, looks like here are some quotes missi=
ng
>> around the YACC_FLAGS. Will have to do some further testing here.
>> When replacing the $(TEST_FLAGS) in the build.ninja by $$(TEST_FLAGS) it
>> looks like to start compiling, also some more tests required.
>>
>> Albert
>>
>>
>>
>> On Wed, May 2, 2018 at 3:09 PM, masaru tsuchiyama <[email protected]>
>> wrote:
>>
>>> Hi
>>>
>>> I found a bug that doxygen can't compile for Ninja generator.
>>> It works for 'Unix Makefiles' generator
>>>
>>> This is the error message.
>>>
>>> ninja: warning: multiple rules generate generated_src/configvalues.h.
>>> builds involving this target will not be correct; continuing anyway [-w
>>> dupbuild=3Dwarn]
>>> ninja: error: build.ninja:2384: bad $-escape (literal $ must be written
>>> as $$)
>>>
>>> This is the diff of build.ninja between good revision (
>>> ok_b6f01ff09b17e5c2288f2418ef0a8f074456c357)
>>> and bad revision (c78c338fffbdbb9b2379b1896e647f7cc697da57)
>>>
>>> $ diff build/build.ninja ok_b6f01ff09b17e5c2288f2418ef0a8f074456c357
>>> 2384c2384
>>> <   COMMAND =3D cd /home/user/gitwork/doxygen/build/testing &&
>>> /usr/bin/python /home/user/gitwork/doxygen/testing/runtests.py
>>> $(TEST_FLAGS) --doxygen /home/user/gitwork/doxygen/build/bin/doxygen
>>> --inputdir /home/user/gitwork/doxygen/testing --outputdir
>>> /home/user/gitwork/doxygen/build/testing
>>> ---
>>> >   COMMAND =3D cd /home/user/gitwork/doxygen/build/testing &&
>>> /usr/bin/python /home/user/gitwork/doxygen/testing/runtests.py --all
>>> --doxygen /home/user/gitwork/doxygen/build/bin/doxygen --inputdir
>>> /home/user/gitwork/doxygen/testing --outputdir
>>> /home/user/gitwork/doxygen/build/testing
>>>
>>> By tweaking  $(TEST_FLAGS) to  --all, the build succeeded.
>>>
>>> This is a script to reproduce.
>>>
>>> -----------------------------------------------------------------------=
--------
>>> #!/bin/sh
>>>
>>> if [ -e build ]; then
>>>   rm -rf build
>>> fi
>>> mkdir build
>>> cd build
>>>
>>> cmake -G Ninja -D CMAKE_BUILD_TYPE=3DRelease ..
>>> cmake --build . -- -j 3 -v || echo error && cd .. && exit 1
>>>
>>> cd ..
>>>
>>> -----------------------------------------------------------------------=
--------
>>>
>>>
>>>
>>>
>>> -----------------------------------------------------------------------=
-------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Doxygen-develop mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/doxygen-develop
>>>
>>>
>>
>

--000000000000d3fec6056b40e890
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><div><br></div><div>I commented to the pull r=
equest.</div><div><br></div></div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr">2018=E5=B9=B45=E6=9C=883=E6=97=A5(=E6=9C=A8) 1:32 Albert &lt;<a hr=
ef=3D"mailto:[email protected]">[email protected]</a>&gt;:<br></d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left=
:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div>I&#39;ve just pushe=
d a proposed patch to github (pull request 712, <a href=3D"https://github.c=
om/doxygen/doxygen/pull/712" target=3D"_blank">https://github.com/doxygen/d=
oxygen/pull/712</a>). <br><br></div>Albert<br></div><div class=3D"gmail_ext=
ra"><br><div class=3D"gmail_quote">On Wed, May 2, 2018 at 4:03 PM, Albert <=
span dir=3D"ltr">&lt;<a href=3D"mailto:[email protected]" target=3D"_b=
lank">[email protected]</a>&gt;</span> wrote:<br><blockquote class=3D"=
gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-=
left:1ex"><div dir=3D"ltr"><div><div><div>Dear Masaru,<br><br></div>A bit s=
trange. The construct as used for TEST_FLAGS is the same construct as used =
for e.g. LEX_FLAGS ad BISON_FLAGS<br>Do you have an idea why it is working =
for LEX_FLAGS / YACC_FLAGS and not for TEST_FLAGS.<br><br></div>I tried to =
create a Ninja version under Windows but I fail due to the fact that cmake =
cannot find bison, looks like here are some quotes missing around the YACC_=
FLAGS. Will have to do some further testing here.<br></div><div>When replac=
ing the $(TEST_FLAGS) in the build.ninja by $$(TEST_FLAGS) it looks like to=
 start compiling, also some more tests required.<br><br></div><div>Albert<b=
r></div><br><div><div><br></div></div></div><div class=3D"gmail_extra"><br>=
<div class=3D"gmail_quote"><div><div class=3D"m_26960274483017668h5">On Wed=
, May 2, 2018 at 3:09 PM, masaru tsuchiyama <span dir=3D"ltr">&lt;<a href=
=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a>&gt;=
</span> wrote:<br></div></div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div clas=
s=3D"m_26960274483017668h5"><div dir=3D"ltr">Hi<div><br></div><div>I found =
a bug that doxygen can&#39;t compile for Ninja generator.</div><div>It work=
s for &#39;Unix Makefiles&#39; generator</div><div><br></div><div>This is t=
he error message.</div><div><br></div><div><div>ninja: warning: multiple ru=
les generate generated_src/configvalues.h. builds involving this target wil=
l not be correct; continuing anyway [-w dupbuild=3Dwarn]</div><div>ninja: e=
rror: build.ninja:2384: bad $-escape (literal $ must be written as $$)</div=
><div><br></div><div>This is the diff of=20

<span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo=
nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font=
-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra=
nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25=
5,255);text-decoration-style:initial;text-decoration-color:initial;float:no=
ne;display:inline">build.ninja</span>=C2=A0between good revision (

<span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo=
nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font=
-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra=
nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25=
5,255);text-decoration-style:initial;text-decoration-color:initial;float:no=
ne;display:inline">ok_b6f01ff09b17e5c2288f2418ef0a8f074456c357)</span></div=
><div>and bad revision (c78c338fffbdbb9b2379b1896e647f7cc697da57)</div><div=
><br></div><div><div>$ diff build/build.ninja ok_b6f01ff09b17e5c2288f2418ef=
0a8f074456c357</div><div>2384c2384</div><div>&lt;=C2=A0 =C2=A0COMMAND =3D c=
d /home/user/gitwork/doxygen/build/testing &amp;&amp; /usr/bin/python /home=
/user/gitwork/doxygen/testing/runtests.py $(TEST_FLAGS) --doxygen /home/use=
r/gitwork/doxygen/build/bin/doxygen --inputdir /home/user/gitwork/doxygen/t=
esting --outputdir /home/user/gitwork/doxygen/build/testing</div><div>---</=
div><div>&gt;=C2=A0 =C2=A0COMMAND =3D cd /home/user/gitwork/doxygen/build/t=
esting &amp;&amp; /usr/bin/python /home/user/gitwork/doxygen/testing/runtes=
ts.py --all --doxygen /home/user/gitwork/doxygen/build/bin/doxygen --inputd=
ir /home/user/gitwork/doxygen/testing --outputdir /home/user/gitwork/doxyge=
n/build/testing</div></div><div><br></div><div>By tweaking=C2=A0

<span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo=
nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font=
-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra=
nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25=
5,255);text-decoration-style:initial;text-decoration-color:initial;float:no=
ne;display:inline">$(TEST_FLAGS) to=C2=A0

<span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo=
nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font=
-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra=
nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25=
5,255);text-decoration-style:initial;text-decoration-color:initial;float:no=
ne;display:inline">--all, the build succeeded.</span></span></div><div><br>=
</div><div>This is a script to reproduce.</div><div>-----------------------=
--------------------------------------------------------</div><div><div>#!/=
bin/sh</div><div><br></div><div>if [ -e build ]; then</div><div>=C2=A0 rm -=
rf build</div><div>fi</div><div>mkdir build</div><div>cd build</div><div><b=
r></div><div>cmake -G Ninja -D CMAKE_BUILD_TYPE=3DRelease ..</div><div>cmak=
e --build . -- -j 3 -v || echo error &amp;&amp; cd .. &amp;&amp; exit 1</di=
v><div><br></div><div>cd ..</div></div><div>

<span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo=
nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font=
-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra=
nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25=
5,255);text-decoration-style:initial;text-decoration-color:initial;float:no=
ne;display:inline">--------------------------------------------------------=
-----------------------</span>

<br></div><div><br></div><div><br></div></div></div>
<br></div></div>-----------------------------------------------------------=
-------------------<br>
Check out the vibrant tech community on one of the world&#39;s most<br>
engaging tech sites, Slashdot.org! <a href=3D"http://sdm.link/slashdot" rel=
=3D"noreferrer" target=3D"_blank">http://sdm.link/slashdot</a><br>_________=
______________________________________<br>
Doxygen-develop mailing list<br>
<a href=3D"mailto:[email protected]" target=3D"_blank">=
[email protected]</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/doxygen-develop" re=
l=3D"noreferrer" target=3D"_blank">https://lists.sourceforge.net/lists/list=
info/doxygen-develop</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div>
</blockquote></div>

--000000000000d3fec6056b40e890--


--===============7713732943162571122==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
--===============7713732943162571122==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Doxygen-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/doxygen-develop

--===============7713732943162571122==--