Re: Build error for Ninja Generator
Albert <[email protected]> Thu, 3 May 2018 09:51:46 +0200
| Newsgroups | gmane.text.doxygen.devel |
|---|---|
| Message-ID | <CABOOx7bNEnmd_3f20mEjKgwqVqrtHxgpDnYOCpUK7Wqi9acSMA@mail.gmail.com> |
--===============5259538039127943251== Content-Type: multipart/alternative; boundary="000000000000b75317056b4879ac" --000000000000b75317056b4879ac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Masaru, I saw the comment n github and commented on it. More important for me is does the solution work. Albert <http://www.avg.com/email-signature?utm_medium=3Demail&utm_source=3Dlink&ut= m_campaign=3Dsig-email&utm_content=3Dwebmail> Virus-free. www.avg.com <http://www.avg.com/email-signature?utm_medium=3Demail&utm_source=3Dlink&ut= m_campaign=3Dsig-email&utm_content=3Dwebmail> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> On Thu, May 3, 2018 at 12:50 AM, masaru tsuchiyama <[email protected]> wrote: > Hi > > I commented to the pull request. > > > 2018=E5=B9=B45=E6=9C=883=E6=97=A5(=E6=9C=A8) 1:32 Albert <albert.tests@gm= ail.com>: > >> I've just pushed a proposed patch to github (pull request 712, >> https://github.com/doxygen/doxygen/pull/712). >> >> Albert >> >> On Wed, May 2, 2018 at 4:03 PM, Albert <[email protected]> wrote: >> >>> Dear Masaru, >>> >>> A bit strange. The construct as used for TEST_FLAGS is the same >>> construct as used for e.g. LEX_FLAGS ad BISON_FLAGS >>> Do you have an idea why it is working for LEX_FLAGS / YACC_FLAGS and no= t >>> for TEST_FLAGS. >>> >>> I tried to create a Ninja version under Windows but I fail due to the >>> fact that cmake cannot find bison, looks like here are some quotes miss= ing >>> around the YACC_FLAGS. Will have to do some further testing here. >>> When replacing the $(TEST_FLAGS) in the build.ninja by $$(TEST_FLAGS) i= t >>> looks like to start compiling, also some more tests required. >>> >>> Albert >>> >>> >>> >>> On Wed, May 2, 2018 at 3:09 PM, masaru tsuchiyama <[email protected]> >>> wrote: >>> >>>> Hi >>>> >>>> I found a bug that doxygen can't compile for Ninja generator. >>>> It works for 'Unix Makefiles' generator >>>> >>>> This is the error message. >>>> >>>> ninja: warning: multiple rules generate generated_src/configvalues.h. >>>> builds involving this target will not be correct; continuing anyway [-= w >>>> dupbuild=3Dwarn] >>>> ninja: error: build.ninja:2384: bad $-escape (literal $ must be writte= n >>>> as $$) >>>> >>>> This is the diff of build.ninja between good revision ( ok_ >>>> b6f01ff09b17e5c2288f2418ef0a8f074456c357) >>>> and bad revision (c78c338fffbdbb9b2379b1896e647f7cc697da57) >>>> >>>> $ diff build/build.ninja ok_b6f01ff09b17e5c2288f2418ef0a8f074456c357 >>>> 2384c2384 >>>> < COMMAND =3D cd /home/user/gitwork/doxygen/build/testing && >>>> /usr/bin/python /home/user/gitwork/doxygen/testing/runtests.py >>>> $(TEST_FLAGS) --doxygen /home/user/gitwork/doxygen/build/bin/doxygen >>>> --inputdir /home/user/gitwork/doxygen/testing --outputdir >>>> /home/user/gitwork/doxygen/build/testing >>>> --- >>>> > COMMAND =3D cd /home/user/gitwork/doxygen/build/testing && >>>> /usr/bin/python /home/user/gitwork/doxygen/testing/runtests.py --all >>>> --doxygen /home/user/gitwork/doxygen/build/bin/doxygen --inputdir >>>> /home/user/gitwork/doxygen/testing --outputdir >>>> /home/user/gitwork/doxygen/build/testing >>>> >>>> By tweaking $(TEST_FLAGS) to --all, the build succeeded. >>>> >>>> This is a script to reproduce. >>>> ------------------------------------------------------------ >>>> ------------------- >>>> #!/bin/sh >>>> >>>> if [ -e build ]; then >>>> rm -rf build >>>> fi >>>> mkdir build >>>> cd build >>>> >>>> cmake -G Ninja -D CMAKE_BUILD_TYPE=3DRelease .. >>>> cmake --build . -- -j 3 -v || echo error && cd .. && exit 1 >>>> >>>> cd .. >>>> ------------------------------------------------------------ >>>> ------------------- >>>> >>>> >>>> >>>> ------------------------------------------------------------ >>>> ------------------ >>>> Check out the vibrant tech community on one of the world's most >>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >>>> _______________________________________________ >>>> Doxygen-develop mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/doxygen-develop >>>> >>>> >>> >> --000000000000b75317056b4879ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div><div>Dear Masaru,<br><br></div>I saw the comment n gi= thub and commented on it. More important for me is does the solution work.<= br><br></div>Albert<br></div><div id=3D"DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF= 2"><br> <table style=3D"border-top:1px solid #d3d4de"> <tr> <td style=3D"width:55px;padding-top:13px"><a href=3D"http://www.avg= .com/email-signature?utm_medium=3Demail&utm_source=3Dlink&utm_campa= ign=3Dsig-email&utm_content=3Dwebmail" target=3D"_blank"><img src=3D"ht= tps://ipmcdn.avast.com/images/icons/icon-envelope-tick-green-avg-v1.png" al= t=3D"" width=3D"46" height=3D"29" style=3D"width: 46px; height: 29px;"></a>= </td> <td style=3D"width:470px;padding-top:12px;color:#41424e;font-size:13px;fo= nt-family:Arial,Helvetica,sans-serif;line-height:18px">Virus-free. <a href= =3D"http://www.avg.com/email-signature?utm_medium=3Demail&utm_source=3D= link&utm_campaign=3Dsig-email&utm_content=3Dwebmail" target=3D"_bla= nk" style=3D"color:#4453ea">www.avg.com</a> </td> </tr> </table><a href=3D"#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2" width=3D"1" heigh= t=3D"1"></a></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote"= >On Thu, May 3, 2018 at 12:50 AM, masaru tsuchiyama <span dir=3D"ltr"><<= a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</= a>></span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0= 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><di= v>Hi</div><div><br></div><div>I commented to the pull request.</div><div><b= r></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr">2018=E5=B9=B4= 5=E6=9C=883=E6=97=A5(=E6=9C=A8) 1:32 Albert <<a href=3D"mailto:albert.te= [email protected]" target=3D"_blank">[email protected]</a>>:<br></div><= div><div class=3D"h5"><blockquote class=3D"gmail_quote" style=3D"margin:0 0= 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div>= I've just pushed a proposed patch to github (pull request 712, <a href= =3D"https://github.com/doxygen/doxygen/pull/712" target=3D"_blank">https://= github.com/doxygen/<wbr>doxygen/pull/712</a>). <br><br></div>Albert<br></di= v><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Wed, May 2, = 2018 at 4:03 PM, Albert <span dir=3D"ltr"><<a href=3D"mailto:albert.test= [email protected]" target=3D"_blank">[email protected]</a>></span> wrote:= <br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-lef= t:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><div><div>Dear Mas= aru,<br><br></div>A bit strange. The construct as used for TEST_FLAGS is th= e same construct as used for e.g. LEX_FLAGS ad BISON_FLAGS<br>Do you have a= n idea why it is working for LEX_FLAGS / YACC_FLAGS and not for TEST_FLAGS.= <br><br></div>I tried to create a Ninja version under Windows but I fail du= e to the fact that cmake cannot find bison, looks like here are some quotes= missing around the YACC_FLAGS. Will have to do some further testing here.<= br></div><div>When replacing the $(TEST_FLAGS) in the build.ninja by $$(TES= T_FLAGS) it looks like to start compiling, also some more tests required.<b= r><br></div><div>Albert<br></div><br><div><div><br></div></div></div><div c= lass=3D"gmail_extra"><br><div class=3D"gmail_quote"><div><div class=3D"m_-5= 62868718301179677m_26960274483017668h5">On Wed, May 2, 2018 at 3:09 PM, mas= aru tsuchiyama <span dir=3D"ltr"><<a href=3D"mailto:[email protected]" = target=3D"_blank">[email protected]</a>></span> wrote:<br></div></div><= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex"><div><div class=3D"m_-562868718301179677m_269= 60274483017668h5"><div dir=3D"ltr">Hi<div><br></div><div>I found a bug that= doxygen can't compile for Ninja generator.</div><div>It works for '= ;Unix Makefiles' generator</div><div><br></div><div>This is the error m= essage.</div><div><br></div><div><div>ninja: warning: multiple rules genera= te generated_src/configvalues.h. builds involving this target will not be c= orrect; continuing anyway [-w dupbuild=3Dwarn]</div><div>ninja: error: buil= d.ninja:2384: bad $-escape (literal $ must be written as $$)</div><div><br>= </div><div>This is the diff of=20 <span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo= nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font= -weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra= nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25= 5,255);text-decoration-style:initial;text-decoration-color:initial;float:no= ne;display:inline">build.ninja</span>=C2=A0between good revision ( <span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo= nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font= -weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra= nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25= 5,255);text-decoration-style:initial;text-decoration-color:initial;float:no= ne;display:inline">ok_<wbr>b6f01ff09b17e5c2288f2418ef0a8f<wbr>074456c357)</= span></div><div>and bad revision (<wbr>c78c338fffbdbb9b2379b1896e647f<wbr>7= cc697da57)</div><div><br></div><div><div>$ diff build/build.ninja ok_<wbr>b= 6f01ff09b17e5c2288f2418ef0a8f<wbr>074456c357</div><div>2384c2384</div><div>= <=C2=A0 =C2=A0COMMAND =3D cd /home/user/gitwork/doxygen/<wbr>build/testi= ng && /usr/bin/python /home/user/gitwork/doxygen/<wbr>testing/runte= sts.py $(TEST_FLAGS) --doxygen /home/user/gitwork/doxygen/<wbr>build/bin/do= xygen --inputdir /home/user/gitwork/doxygen/<wbr>testing --outputdir /home/= user/gitwork/doxygen/<wbr>build/testing</div><div>---</div><div>>=C2=A0 = =C2=A0COMMAND =3D cd /home/user/gitwork/doxygen/<wbr>build/testing &&am= p; /usr/bin/python /home/user/gitwork/doxygen/<wbr>testing/runtests.py --al= l --doxygen /home/user/gitwork/doxygen/<wbr>build/bin/doxygen --inputdir /h= ome/user/gitwork/doxygen/<wbr>testing --outputdir /home/user/gitwork/doxyge= n/<wbr>build/testing</div></div><div><br></div><div>By tweaking=C2=A0 <span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo= nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font= -weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra= nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25= 5,255);text-decoration-style:initial;text-decoration-color:initial;float:no= ne;display:inline">$(TEST_FLAGS) to=C2=A0 <span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo= nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font= -weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra= nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25= 5,255);text-decoration-style:initial;text-decoration-color:initial;float:no= ne;display:inline">--all, the build succeeded.</span></span></div><div><br>= </div><div>This is a script to reproduce.</div><div>-----------------------= -------<wbr>------------------------------<wbr>-------------------</div><di= v><div>#!/bin/sh</div><div><br></div><div>if [ -e build ]; then</div><div>= =C2=A0 rm -rf build</div><div>fi</div><div>mkdir build</div><div>cd build</= div><div><br></div><div>cmake -G Ninja -D CMAKE_BUILD_TYPE=3DRelease ..</di= v><div>cmake --build . -- -j 3 -v || echo error && cd .. &&= exit 1</div><div><br></div><div>cd ..</div></div><div> <span style=3D"color:rgb(34,34,34);font-family:sans-serif;font-size:14px;fo= nt-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font= -weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-tra= nsform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,25= 5,255);text-decoration-style:initial;text-decoration-color:initial;float:no= ne;display:inline">------------------------------<wbr>---------------------= ---------<wbr>-------------------</span> <br></div><div><br></div><div><br></div></div></div> <br></div></div>------------------------------<wbr>------------------------= ------<wbr>------------------<br> Check out the vibrant tech community on one of the world's most<br> engaging tech sites, Slashdot.org! <a href=3D"http://sdm.link/slashdot" rel= =3D"noreferrer" target=3D"_blank">http://sdm.link/slashdot</a><br>_________= _____________________<wbr>_________________<br> Doxygen-develop mailing list<br> <a href=3D"mailto:[email protected]" target=3D"_blank">= Doxygen-develop@lists.<wbr>sourceforge.net</a><br> <a href=3D"https://lists.sourceforge.net/lists/listinfo/doxygen-develop" re= l=3D"noreferrer" target=3D"_blank">https://lists.sourceforge.net/<wbr>lists= /listinfo/doxygen-develop</a><br> <br></blockquote></div><br></div> </blockquote></div><br></div> </blockquote></div></div></div> </blockquote></div><br></div> --000000000000b75317056b4879ac-- --===============5259538039127943251== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot --===============5259538039127943251== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Doxygen-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/doxygen-develop --===============5259538039127943251==--