Some thoughts about packaging and compilation...

Hi everyone,

I've done the newest 0.9.8-pre1 package (still for cooker) and 
encountered the same problems as i had before.

1 - there is no specific option to define the doc directory.

By default it builds on 
/usr/(local/)share/doc/refdb-<version><-prerelease>/ although in the rpm 
build process (basically uncompress, run autotools and configure, make, 
make install), the doc directory is /usr/(local/)share/doc/refdb-<version>/
(please note there is no <-prerelease> although in this case there is one).

I've not get where the difference comes from but i suspect the 
install.sh you provide in scripts/ to produce this difference in behaviours.

2 - i've slightly modify the scripts/refdb.in to get two points into 
account:
	a) Mandriva uses pinit and thus needs specific headers (nothing to do 
with refDB though)
	b) i add the 'status' option in the cases (not sure this is completely 
portable), and correct the *) case since it misses some existing options:

Original:
      *)
-       echo "Usage: $(basename $0) {start|stop}" >&2
-       exit 1;;
Corrected:

+       echo "Usage: $(basename $0) 
{start|stop|status|restart|force-reload}" >&2
+       RETVAL 1
+       ;;

In your provided script, the options restart and force-reload are 
mentionned so i presume this is a good thing to indicate it in the Usage 
line. (do not bother about the RETVAL 1, this is exactly the same as 
exit 1).

3 - some permissions seem incorrect:
-rwxr-xr-x  1 steletch mig  1403 avr 14 00:07 AUTHORS*
-rwxr-xr-x  1 steletch mig 29746 avr 14 00:07 COPYING*
-rwxr-xr-x  1 steletch mig  2964 jun 25 23:38 INSTALL*
-rwxr-xr-x  1 steletch mig 10280 avr 14 00:07 missing*
-rwxr-xr-x  1 steletch mig 30690 jun 25 15:39 NEWS*
-rwxr-xr-x  1 steletch mig  8876 mai 26 15:47 README*
-rw-r--r--  1 steletch mig 12660 mai 27 23:18 UPGRADING

All of these should be 644 instead of 755 (no executable bit ...) since 
they are only texty files ;-).

Those are details but since i cannot help much in coding, i try to get 
some feedback on little things ;-)

Hoping this will help ;-)

Cheers,

Stéphane

-- 
Stéphane Téletchéa, PhD.                  http://www.steletch.org
Unité Mathématique Informatique et Génome http://migale.jouy.inra.fr/mig
INRA, Domaine de Vilvert                  Tél : (33) 134 652 891
78352 Jouy-en-Josas cedex, France         Fax : (33) 134 652 901

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642